Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: scrollToQuery incorrect targets #944

Merged
merged 2 commits into from
Sep 27, 2021
Merged

Conversation

alfonsobries
Copy link
Member

Summary

https://app.clickup.com/t/1hk1up9

Fixes some incorrect references used on the scrollToQuery after page changes on livewire

Checklist

  • I checked my UI changes against the design and there are no notable differences
  • I checked my UI changes for any responsiveness issues
  • I checked my UI changes in light AND dark mode
  • I checked my (code) changes for obvious issues, debug statements and commented code
  • I opened a corresponding card on Clickup for any remaining TODOs in my code
  • I added a short description on how to test this PR (if necessary)
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@alfonsobries alfonsobries changed the title fix: scrollTo incorrect references fix: scrollToQuery incorrect targets Sep 24, 2021
@ItsANameToo ItsANameToo merged commit 7f7274d into develop Sep 27, 2021
@ItsANameToo ItsANameToo deleted the fix/scroll-callback-ids branch September 27, 2021 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants