Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: reduce overhead of various methods #31

Merged
merged 7 commits into from
Sep 30, 2019
Merged

Conversation

faustbrian
Copy link
Contributor

Summary

  • Migrate some fast.js methods over and remove unnecessary functionality.
  • Remove the ability to pass strings as iteratees, always expect a function.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ghost ghost added Complexity: High More than 256 lines changed. Type: Performance The issue or pull request relates to performance. labels Sep 30, 2019
@codecov
Copy link

codecov bot commented Sep 30, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@94ec7ef). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##             master    #31   +/-   ##
=======================================
  Coverage          ?   100%           
=======================================
  Files             ?    142           
  Lines             ?    786           
  Branches          ?     91           
=======================================
  Hits              ?    786           
  Misses            ?      0           
  Partials          ?      0
Impacted Files Coverage Δ
src/pull-all.ts 100% <100%> (ø)
src/uniq-by.ts 100% <100%> (ø)
src/index.ts 100% <100%> (ø)
src/internal/compound-words.ts 100% <100%> (ø)
src/key-by.ts 100% <100%> (ø)
src/reduce.ts 100% <100%> (ø)
src/map-values.ts 100% <100%> (ø)
src/map-object.ts 100% <100%> (ø)
src/reduce-right-array.ts 100% <100%> (ø)
src/pluck.ts 100% <100%> (ø)
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94ec7ef...37b1fdf. Read the comment docs.

@faustbrian faustbrian changed the title perf: reduce overhead of various performance perf: reduce overhead of various methods Sep 30, 2019
@faustbrian faustbrian merged commit b779d03 into master Sep 30, 2019
@faustbrian faustbrian deleted the refactor/deps branch September 30, 2019 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: High More than 256 lines changed. Type: Performance The issue or pull request relates to performance.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant