Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: native bigint #33

Merged
merged 5 commits into from
Oct 2, 2019
Merged

fix: native bigint #33

merged 5 commits into from
Oct 2, 2019

Conversation

spkjp
Copy link
Contributor

@spkjp spkjp commented Oct 2, 2019

Summary

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@spkjp spkjp requested a review from faustbrian as a code owner October 2, 2019 17:41
@ghost ghost added Complexity: Low Less than 64 lines changed. Type: Bugfix The pull request fixes an incorrect functionality or behaviour. labels Oct 2, 2019
faustbrian
faustbrian suggested changes Oct 2, 2019
View reviewed changes
src/big-number.ts Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 2, 2019 •
edited
Loading

Codecov Report

Merging #33 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #33   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files         145    145           
  Lines         848    848           
  Branches       98     98           
=====================================
  Hits          848    848
Impacted Files Coverage Δ
src/big-number.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 145abb4...e89a642. Read the comment docs.

@faustbrian faustbrian merged commit e4f9eac into master Oct 2, 2019
@ghost ghost deleted the wip/native-bigint branch October 2, 2019 21:32
@ghost ghost mentioned this pull request Oct 6, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@faustbrian faustbrian faustbrian approved these changes

Assignees
No one assigned
Labels
Complexity: Low Less than 64 lines changed. Type: Bugfix The pull request fixes an incorrect functionality or behaviour.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spkjp @faustbrian