Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Paths to image files should be relative #19

Closed
dzc34 opened this issue Jan 26, 2017 · 0 comments
Closed

Paths to image files should be relative #19

dzc34 opened this issue Jan 26, 2017 · 0 comments

Comments

@dzc34
Copy link
Member

dzc34 commented Jan 26, 2017

Observed behaviour

like #7 for /Images/good.jpg

When installed into a directory (says cf and not contrast-finder), and configured behind an Apache+mod_proxy_html configured with ProxyPass, the CSS of Contrast-Finder app are not loaded.

The paths of CSS files are absolutes (beginning with a slash), thus can't be correctly translated by the ProxyPass directive

Steps to reproduce the behaviour

https://app.contrast-finder.org/result.html?foreground=%23396F3A&background=%23DFF0D8&isBackgroundTested=false&ratio=4.5&algo=HSV

Your configuration

Contrast-Finder 0.4.3 ( 2017-01-24)
@dzc34 dzc34 closed this as completed in b0f6f81 Jan 26, 2017
dzc34 referenced this issue Feb 2, 2017
@mfaure @dzc34
.jsp - added comments -----> do not merge
7d2f09d
dzc34 added a commit to dzc34/Contrast-Finder that referenced this issue Feb 12, 2017
@dzc34
Contrast-Finder v0.4.4
e79eda0 
----------------------

  set version to 0.4.4
  fixed Asqatasun#28 - Color contrast falling for links (:hover, :focus)
  compile_and_build_docker_image.sh : added option to skip unit tests
  updated changelog
  compile_and_build_docker_image.sh : added --build-only-* options
  updated other-contrast-tools.md
  typo
  .jsp - added comments
  fix "refactor package names color.finder --> contrastFinder"
  refactor package names color.finder --> contrastFinder
  removed highRatio stuff
  added Javadoc
  enhance i18n
  DOC explained ratio
  added .editorconfig
  webapp: added HTTP security headers (fixed Asqatasun#23)
  updated CHANGELOG
  fixed Asqatasun#21 : added space between sampleText and sampleTextBold
  Upgraded SpringFramework to v4.3.6 (fixed Asqatasun#22)
  webapp: updated lang switcher
  webapp: removed "Fork me on GitHub"
  webapp - Lang cookie: added cookieMaxAge (2 months) (fixed Asqatasun#20)
  typo
  fixed Asqatasun#19
  CHANGELOG : added missing entry for 0.4.3
  set version to 0.4.4-dev
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dzc34