Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't expose session ID in the URL #9

Closed
dzc34 opened this issue Jan 12, 2017 · 2 comments
Closed

don't expose session ID in the URL #9

dzc34 opened this issue Jan 12, 2017 · 2 comments
Labels
bug perf

Comments

@dzc34
Copy link
Member

dzc34 commented Jan 12, 2017 •
edited
Loading

Observed behaviour

/result.html;jsessionid=1C22591EA3096B15B6D026154F236FCE?foreground=%23468847&(...)

Expected behaviour

/result.html?foreground=%23468847&(...)

Configuration

same result for two tests:

  1. docker
  2. https://app.contrast-finder.org
@dzc34 dzc34 closed this as completed in 15923ed Jan 12, 2017
dzc34 added a commit to dzc34/Contrast-Finder that referenced this issue Jan 12, 2017
@dzc34
Contrast-Finder v0.4.1
be59e70 
----------------------

  set version to 0.4.1
  Updated RELEASE/Dockerfile
  typo
  Added useHttpOnly flag for session ID (fixed Asqatasun#9)
  typo Tomcat/Dockerfile
  Docker image based on Tomcat7 image OK
  Enhanced docker image based on Tomcat7 (still WIP)
  Dockerfile FROM tomcat:8.0-jre7 : not working (WIP)
  Fixed edge cases on tests
  typo
  Webapp - Used input tag type=color instead off type=text (fixed Asqatasun#2)
  typo
  Updated docker/SNAPSHOT-local*
  updated .gitignore
  fixed descriptor.xml
  added descriptor.xml (building tar.gz with maven)
  refactor packaging
  set version to 0.4.1-dev
@dzc34 dzc34 added the bug label Jan 14, 2017
@dzc34
Copy link
Member Author

dzc34 commented Jan 18, 2017

Not fixed
Now different result for both tests:

  • docker ---> OK
  • https://app.contrast-finder.org ----> KO

@dzc34 dzc34 reopened this Jan 18, 2017
@dzc34
Copy link
Member Author

dzc34 commented Jan 26, 2017 •
edited
Loading

fixed e311878

@dzc34 dzc34 closed this as completed Jan 26, 2017
@dzc34 dzc34 added the perf label Jan 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug perf
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dzc34