Error [AssertionError]: assertion failed

[trusktr]

I'm getting an error without a helpful message like

{ Error [AssertionError]: assertion failed
    at t.assert (/Users/trusktr/src/infamous+glas/node_modules/as-pect/node_modules/assemblyscript/dist/assemblyscript.js:1:527996)

Note, I'm trying to run tests with as-pect.

Here's the full output:

infamous+glas git:master ❯ npm test

> @ test /Users/trusktr/src/infamous+glas
> asp --reporter=SummaryTestReporter

       ___   _____                       __    
      /   | / ___/      ____  ___  _____/ /_   
     / /| | \__ \______/ __ \/ _ \/ ___/ __/   
    / ___ |___/ /_____/ /_/ /  __/ /__/ /_     
   /_/  |_/____/     / .___/\___/\___/\__/     
                    /_/                        

  ⚡AS-pect⚡ Test suite runner [1.0.0-beta]
  
[Log] Using configuration /Users/trusktr/src/infamous+glas/as-pect.config.js
[Log] Including files: src/as/**/*.spec.ts
[Log] Running tests that match: .*
[Log] Running groups that match: .*

✔ src/as/__tests__/example.spec.ts Pass: 1 / 1 Todo: 0 Time: 1.872ms
✔ src/as/glas/core/Layers.spec.ts Pass: 5 / 5 Todo: 0 Time: 2.56ms
There was a compilation error when trying to create the wasm binary for file: src/as/glas/math/Color.spec.ts.
{ Error [AssertionError]: assertion failed
    at t.assert (/Users/trusktr/src/infamous+glas/node_modules/as-pect/node_modules/assemblyscript/dist/assemblyscript.js:1:527996)
    at t.makeCallDirect (/Users/trusktr/src/infamous+glas/node_modules/as-pect/node_modules/assemblyscript/dist/assemblyscript.js:1:295254)
    at t.compileCallExpression (/Users/trusktr/src/infamous+glas/node_modules/as-pect/node_modules/assemblyscript/dist/assemblyscript.js:1:282523)
    at t.compileExpression (/Users/trusktr/src/infamous+glas/node_modules/as-pect/node_modules/assemblyscript/dist/assemblyscript.js:1:239421)
    at t.compileExpressionStatement (/Users/trusktr/src/infamous+glas/node_modules/as-pect/node_modules/assemblyscript/dist/assemblyscript.js:1:228716)
    at t.compileStatement (/Users/trusktr/src/infamous+glas/node_modules/as-pect/node_modules/assemblyscript/dist/assemblyscript.js:1:225068)
    at t.compileStatements (/Users/trusktr/src/infamous+glas/node_modules/as-pect/node_modules/assemblyscript/dist/assemblyscript.js:1:226077)
    at t.compileFunctionBody (/Users/trusktr/src/infamous+glas/node_modules/as-pect/node_modules/assemblyscript/dist/assemblyscript.js:1:215093)
    at t.compileFunction (/Users/trusktr/src/infamous+glas/node_modules/as-pect/node_modules/assemblyscript/dist/assemblyscript.js:1:217815)
    at t.compileFunctionExpression (/Users/trusktr/src/infamous+glas/node_modules/as-pect/node_modules/assemblyscript/dist/assemblyscript.js:1:300205) message: 'assertion failed' }

Here's reproduction:

git clone git@github.com:infamous/glas.git
cd glas
git checkout assemblyscript-issue-645
npm install
npm test
// error

The code in question is being called on this line:

https://github.com/infamous/glas/blob/bea0737beffb863239c9bd7149ec9a133a10f7f8/src/as/glas/math/Color.spec.ts#L34

And that set method is here:

https://github.com/infamous/glas/blob/assemblyscript-issue-645/src/as/glas/math/Color.ts#L230-L244

Any idea why the error?

[trusktr]

How can I give better error output (the above stack trace points one-line minified code)?

[jtenner]

You should gist the source code for the test suite so I can take a look at it. Especially if it's related to aspect.

…

On Sun, Jun 9, 2019, 7:19 PM Joe Pea ***@***.***> wrote: How can I give better error output (the above stack trace points one-line minified code)? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#645?email_source=notifications&email_token=AA4WJO2QX3Q2JN7KWVRU65LPZWFZJA5CNFSM4HWPPOMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXIUHRA#issuecomment-500253636>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA4WJO5MTV35DBZT2DDQLMTPZWFZJANCNFSM4HWPPOMA> .

[trusktr]

@jtenner Hi, I updated the original post a reproduction:

The code in question is being called on this line:

https://github.com/infamous/glas/blob/bea0737beffb863239c9bd7149ec9a133a10f7f8/src/as/glas/math/Color.spec.ts#L34

And that set method is here:

https://github.com/infamous/glas/blob/assemblyscript-issue-645/src/as/glas/math/Color.ts#L230-L244

[trusktr]

@jtenner Thanks for looking into it!

[trusktr]

Alright, getting this error again, and I have another reproduction without as-pect:

ERROR: AssertionError: assertion failed
    at name (/Users/trusktr/src/infamous+glas/node_modules/assemblyscript/dist/webpack:/assemblyscript/std/portable/index.js:180:1)
    at t.parameterTypes (/Users/trusktr/src/infamous+glas/node_modules/assemblyscript/dist/webpack:/assemblyscript/src/compiler.ts:6689:43)
    at t.resolveFunction [as compileCallExpression] (/Users/trusktr/src/infamous+glas/node_modules/assemblyscript/dist/webpack:/assemblyscript/src/compiler.ts:5863:36)
    at t.compileBinaryExpression [as compileExpression] (/Users/trusktr/src/infamous+glas/node_modules/assemblyscript/dist/webpack:/assemblyscript/src/compiler.ts:2758:21)
    at t.compileExpressionRetainType (/Users/trusktr/src/infamous+glas/node_modules/assemblyscript/dist/webpack:/assemblyscript/src/compiler.ts:2848:3)
    at Object.nonNullableType [as compileCall] (/Users/trusktr/src/infamous+glas/node_modules/assemblyscript/dist/webpack:/assemblyscript/src/builtins.ts:2082:51)
    at t.makeMap [as compileCallExpressionBuiltin] (/Users/trusktr/src/infamous+glas/node_modules/assemblyscript/dist/webpack:/assemblyscript/src/compiler.ts:6032:9)
    at typeArguments [as compileCallExpression] (/Users/trusktr/src/infamous+glas/node_modules/assemblyscript/dist/webpack:/assemblyscript/src/compiler.ts:5772:40)
    at t.compileBinaryExpression [as compileExpression] (/Users/trusktr/src/infamous+glas/node_modules/assemblyscript/dist/webpack:/assemblyscript/src/compiler.ts:2758:21)
    at t.prototype [as compileExpressionStatement] (/Users/trusktr/src/infamous+glas/node_modules/assemblyscript/dist/webpack:/assemblyscript/src/compiler.ts:1960:3)

reproduction:

git clone git@github.com:infamous/glas.git
cd glas
git checkout assemblyscript-issue-645-2
npm install
# the following causes the build error:
asc src/as/glas/index.ts -b build/as/glas/untouched.wasm -t build/as/glas/untouched.wat --sourceMap --validate --debug

Maybe it's a different problem, just with similar error message.

Basically the code is

	test2<T>(t: T): boolean {
		if (isFloat<T>(t)) {
			return true
		} else if (isString<T>(t)) {
			return true
		}

		return false
	}

and the callsite is

	assert(a.test2(2), 'test2 failed')
	assert(!a.test2(null), 'test2 failed')

[willemneal]

I just tried this out and this is something that I've had to grapple with when using generics. The offending line in the assertion error is this:

at t.parameterTypes (/Users/trusktr/src/infamous+glas/node_modules/assemblyscript/dist/webpack:/assemblyscript/src/compiler.ts:6689:43).

Essentially you need to still provide the generic argument to test2. I downloaded the code and tested it out and indeed adding the types solves the problem.

        assert(a.test2<i32>(2), 'test2 failed')
        assert(!a.test2<string>(null), 'test2 failed')

This issue should serve as a request for better error messages for errors involving generics.

[trusktr]

I ran into this again. The error message isn't so helpful (same stack as above). Here's a reproduction:

git clone git@github.com:infamous/glas.git
cd glas
git checkout assemblyscript-issue-645-3
npm install
# the following causes the compile error:
npx asc src/as/glas/index.ts -b build/as/glas/untouched.wasm -t build/as/glas/untouched.wat --sourceMap --validate --debug

[trusktr]

@willemneal Ah, I see what you mean!

The error message could be improved, f.e. "generic arg is missing" or "generic arg is required".

[trusktr]

I thought the generic arg was inferred from the callsite, like in regular TypeScript, so that's why I didn't think to call it with a type arg (that's why my editor doesn't complain about type errors).

@MaxGraey @jtenner @dcodeIO Is there a plan for more helpful error messages? What about for inferred type args?

[trusktr]

@willemneal On the last reproduction, #645 (comment), I was missing type args, and I added them but I'm still getting the error. Am I doing something wrong in checking the args in the conditional?

f.e.

	add<T>(object: T): this {
		let o: Object3D | null = null

		if (Array.isArray<Object3D>(object)) {
			for (let i = 0, l = object.length; i < l; i++) {
				o = object[i]

				// this conditional check is pointless, because we know the object will be
				// an Object3D here, but it is needed for type checking to work, and will be
				// optimized away in the compiler output.
				if (o instanceof Object3D) this.__add(o)
			}
		} else if (object instanceof Object3D) {
			this.__add(object)
		} else {
			throw new Error('Object3D.add: The argument should be an Object3D or Array<Object3D>')
		}

		return this
	}

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.