[Bug fix] Fix the bug about map.keys and map.values #1004
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2. Add test cases for map.keys and map.values Signed-off-by: Liao.Peng <pengliao@live.cn>
Signed-off-by: Liao.Peng <pengliao@live.cn>
|
Good find, seems this broke when I removed |
dcodeIO
reviewed
Dec 13, 2019
dcodeIO
reviewed
Dec 13, 2019
Signed-off-by: Liao.Peng <pengliao@live.cn>
|
set.values has same problem: https://github.com/AssemblyScript/assemblyscript/blob/master/std/assembly/set.ts#L190. Could you fix that in this PR as well? |
Signed-off-by: Liao.Peng <pengliao@live.cn>
|
I'm glad to do this. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the about map.keys and map.values and set.values.
Because of initializing the array of keys and value with size, so using
pushwill append data to array.Add test cases for map.keys, map.values and set.values.