add basic String#localeCompare #1008
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcodeIO
reviewed
Jan 2, 2020
dcodeIO
reviewed
Jan 10, 2020
| // <SP>, <TAB>, <LF>, <VT>, <FF>, <CR> and <NBSP> | ||
| return c == 0x20 || <u32>(c - 0x09) <= 0x0D - 0x09 || c == 0xA0; | ||
| // @ts-ignore: cast | ||
| return ((c | 0x80) == 0xA0) | (u32(c - 0x09) <= 0x0D - 0x09); |
There was a problem hiding this comment.
Can you explain what changed here?
There was a problem hiding this comment.
Sure. If we slightly rearrange original condition as:
(c == 0x20 || c == 0xA0) || <u32>(c - 0x09) <= 0x0D - 0x09and convert 0x20 and 0xA0 to binary:
0b00100000 // 0x20
0b10100000 // 0xA0
// also
0b10000000 // 0x80we could see (c | 0b10000000) == 0b10100000 always true for 0b00100000 or 0b10100000 and false overwise
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.