Fix managed function expression return #1027
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
btw I'm wondering why this local.tee $0
call $~lib/rt/pure/__retain
local.get $0
call $~lib/rt/pure/__releasenot optimized by binaryen's Optimize ARC pass. It seems that remove RC methods for |
|
The pass collects retains of the form |
It already solved in this PR, but I thought it shouldn't be a problem for post-assemblyscript pass: I guess we have that patterns in other places buy I'm not sure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #1026 there is an issue when a managed reference is returned from function expressions using just a single expression.
To fix this, I ultimately decided to unify preparation of potentially managed return values by reusing autorelease undo functionality originally implemented for branch unification. As a side-effect this also gets rid of various unnecessary retain/release pairs whenever the undo succeeded.
fixes #1026