Prepare for Binaryen compiled to Wasm #1029
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
On typedarray test optimization example. Current (binaryen wasm): 3957 ms |
dcodeIO
changed the title
|
This keeps using the JS variant (for now) so existing transforms that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR naively instructs
ascto use the Wasm variant of Binaryen, resulting in the parallel tests completing in 14s compared to 19s on my machine.This has major problems still, though, since one can't just
require("assemblyscript")before Binaryen has been loaded and is ready due to all the Binaryen ops becoming aliased to enums insrc/module.ts, which runs immediately. I guess the API has to be reworked to account for this properly.