Skip to content

Improve lowercase mapping and handle contextual dependent Sigma symbol #1113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 42 commits into from
Feb 27, 2020
Merged

Improve lowercase mapping and handle contextual dependent Sigma symbol #1113

merged 42 commits into from
Feb 27, 2020

Conversation

MaxGraey
Copy link
Member

@MaxGraey MaxGraey commented Feb 16, 2020 •
edited
Loading

DONE

  • add more tests

MaxGraey
MaxGraey commented Feb 16, 2020
View reviewed changes
@MaxGraey MaxGraey changed the title lowercase mapping. Extra special conditional handling for Sigma symbol [WIP] lowercase mapping. Extra special conditional handling for Sigma symbol Feb 16, 2020
@MaxGraey
Copy link
Member Author

MaxGraey commented Feb 16, 2020 •
edited
Loading

need also Case Ignorable & Cased maps...

@MaxGraey
Copy link
Member Author

Alright. Now we have got working version at last. Let's optimize it!

@MaxGraey MaxGraey changed the title [WIP] lowercase mapping. Extra special conditional handling for Sigma symbol Improve lowercase mapping and handle contextual dependent Sigma symbol Feb 22, 2020
@MaxGraey
Copy link
Member Author

MaxGraey commented Feb 22, 2020 •
edited
Loading

Catched SEGFAULT on v8! 😱

dcodeIO
dcodeIO reviewed Feb 23, 2020
View reviewed changes
@MaxGraey MaxGraey requested a review from dcodeIO February 23, 2020 14:19
@MaxGraey
Copy link
Member Author

It seems it very important for Greek speakers according to this tweet =)
https://twitter.com/LeaVerou/status/606895152284602368

dcodeIO
dcodeIO reviewed Feb 26, 2020
View reviewed changes
dcodeIO
dcodeIO reviewed Feb 26, 2020
View reviewed changes
dcodeIO
dcodeIO reviewed Feb 26, 2020
View reviewed changes
dcodeIO
dcodeIO reviewed Feb 26, 2020
View reviewed changes
dcodeIO
dcodeIO reviewed Feb 26, 2020
View reviewed changes
@dcodeIO
Copy link
Member

dcodeIO commented Feb 26, 2020

LGTM with the comments above addressed :)

@MaxGraey MaxGraey requested a review from dcodeIO February 27, 2020 00:58
dcodeIO
dcodeIO reviewed Feb 27, 2020
View reviewed changes
@dcodeIO dcodeIO merged commit aa1774c into AssemblyScript:master Feb 27, 2020
@MaxGraey MaxGraey deleted the handle-lower-case-sigma branch February 27, 2020 17:53
@dcodeIO
Copy link
Member

dcodeIO commented Feb 27, 2020

Thanks! :)

@MaxGraey MaxGraey mentioned this pull request Oct 5, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcodeIO dcodeIO dcodeIO left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MaxGraey @jtenner @dcodeIO