Remove fast log exp and pow methods introduced in #992 #1130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's how issue looks like:
Actually it appears with such math expr with double logarithm and pretty big arguments |
|
I reproduced this with original musl library so can confirm it implementation issue (not portable mistake). We can't use this functions. @dcodeIO plz merge this asap |
dcodeIO
reviewed
Feb 29, 2020
MaxGraey
changed the title
|
Live wasm demo via emscripten: https://maxgraey.github.io/mandelbrot-issue-demo |
|
Issue was solved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to some precision regressions in new fast exp_lut, log_lut and pow_lut methods I temporary disabled them until I find out if there are general implementation problems or just some errors made me during the porting process.