Fix columns being off by one / implement line cache #1174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcodeIO
commented
Mar 15, 2020
dcodeIO
commented
Mar 15, 2020
MaxGraey
approved these changes
Mar 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turned out that column numbers in diagnostics used to be off by one, starting at 0 instead of 1.
Also took the opportunity to implement a line cache aiding in determining the line number for a given source position using a little binary search instead of walking the source. Saves a second or so on the non-parallel test suite (~1.8%).
In turn I also removed the
Range#lineandRange#columnproperties in preparation of making the AST more easily serializable eventually.