Move optimization pipeline from JS to Wasm #1234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nice! Just one suggestion, could you merge #1227 first? |
|
Yep, was going to ask about that. So let's merge your PR first :) |
|
Alright, moved the new pipeline to Wasm, and from the fixtures this appears to be identical. Also removed most of the "differs" comments, as these seem not very useful anymore with the pipeline diverging so much, and tried to shorten the remaining ones. |
MaxGraey
approved these changes
Apr 21, 2020
This was referenced Sep 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Started as an experiment, but worked out well, so here it is.