Rework memory options #1268
Merged
Rework memory options #1268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1242 by reworking the memory options available on the command line:
--noExportMemorydoes not export the memory.--initialMemory PAGESsets the initial memory size in pages.--maximumMemory PAGESsets the maximum memory size in pages.--sharedMemorydeclares memory as shared. Requires maximumMemory.The first three options just override otherwise default behavior (exported by default, initial size is what's required, maximum size is allowed to grow to 4GB), so these are backwards compatible. The change to
--sharedMemoryis breaking, in that it previously required the maximum size of memory as an integer argument (as required by the spec), which is now a separate option, with sharedMemory now being a boolean flag.