Skip to content

Refactor and clean up Binaryen bindings #1889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 7, 2021
Merged

Refactor and clean up Binaryen bindings #1889

merged 3 commits into from
Jun 7, 2021

Conversation

dcodeIO
Copy link
Member

@dcodeIO dcodeIO commented Jun 6, 2021

  • Removes redundant bindings for Binaryen constants (no need to maintain these)
  • Renames the oddly named NativeType to TypeRef
  • Makes the binding's type definitions the single source of truth
  • Adds comments for reference
  • I've read the contributing guidelines

@dcodeIO dcodeIO requested a review from MaxGraey June 7, 2021 10:42
MaxGraey
MaxGraey approved these changes Jun 7, 2021
View reviewed changes
Copy link
Member

@MaxGraey MaxGraey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dcodeIO dcodeIO merged commit bee6a9f into main Jun 7, 2021
@dcodeIO dcodeIO deleted the binaryen-refactor branch June 18, 2021 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxGraey MaxGraey MaxGraey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dcodeIO @MaxGraey