Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: #2204, #2211 resolve loop #2264

Merged
merged 8 commits into from
Jul 23, 2022
Merged

fix: #2204, #2211 resolve loop #2264

merged 8 commits into from
Jul 23, 2022

Conversation

technohippy
Copy link
Member

⯈fix: #2204
⯈fix: #2211

  • I've read the contributing guidelines
  • I've added my name and email to the NOTICE file

romdotdog
romdotdog reviewed Apr 15, 2022
View reviewed changes
Copy link
Contributor

@romdotdog romdotdog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should use an O(1) Set<Expression> instead of an Expression[]

dcodeIO
dcodeIO reviewed Apr 23, 2022
View reviewed changes
src/resolver.ts Outdated Show resolved Hide resolved
dcodeIO
dcodeIO reviewed Apr 23, 2022
View reviewed changes
src/resolver.ts Outdated Show resolved Hide resolved
@dcodeIO dcodeIO merged commit 92ea1c4 into AssemblyScript:main Jul 23, 2022
@dcodeIO
Copy link
Member

dcodeIO commented Jul 23, 2022

Thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcodeIO dcodeIO dcodeIO left review comments

@romdotdog romdotdog romdotdog left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

typeof a recursive declaration crashes the compiler Declaration that indexes itself crashes the compiler
3 participants
@technohippy @dcodeIO @romdotdog