Skip to content

fix: Generalize TypedArray#set #2388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Aug 7, 2022
Merged

fix: Generalize TypedArray#set #2388

merged 8 commits into from
Aug 7, 2022

Conversation

MaxGraey
Copy link
Member

@MaxGraey MaxGraey commented Jul 27, 2022 •
edited
Loading

Now it accepts ArrayLike<number> which allow doing this:

let arr = new Uint32Array(3);
arr.set([1, 2, 3]);

without warnings

  • Additionally refactor TypedArray#set and some definitions
  • I've read the contributing guidelines
  • I've added my name and email to the NOTICE file

@MaxGraey MaxGraey requested a review from dcodeIO July 27, 2022 19:29
@MaxGraey MaxGraey merged commit 7db1006 into AssemblyScript:main Aug 7, 2022
@MaxGraey MaxGraey deleted the fix-typedarr-set-defs branch August 7, 2022 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcodeIO dcodeIO dcodeIO approved these changes

Assignees
No one assigned
Labels
compatibility enhancement standard library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MaxGraey @dcodeIO