Fixed demangles an assemblyscript module #363
Conversation
|
These look like good changes to me. Going to break code that uses explicit |
|
LGTM |
lib/loader/index.js
Outdated
| @@ -265,6 +265,7 @@ function demangle(exports, baseModule) { | |||
| let classElem = curr[className]; | |||
| if (typeof classElem === "undefined" || !classElem.prototype) { | |||
| let ctor = function(...args) { | |||
| args.unshift(null); // pass null pointer for class constructor of AssemblyScript | |||
| return ctor.wrap(ctor.prototype.constructor(...args)); | |||
There was a problem hiding this comment.
Would be a bit more efficient to write as return ctor.wrap(ctor.prototype.constructor(0, ...args)); I think
lib/loader/index.js
Outdated
| value: function (...args) { | ||
| args.unshift(this.this); | ||
| setargc(args.length); | ||
| return elem(...args); |
There was a problem hiding this comment.
Similar: return elem(this.this, ...args);
There was a problem hiding this comment.
@dcodeIO this.this looks strange. May be better rename it to self or value for object's value in wrap function?
There was a problem hiding this comment.
I only used .this as the property name because is is less likely to conflict with a class's own fields and methods. Could still conflict, though.
There was a problem hiding this comment.
got it. What about using Symbol?
|
done! |
|
@dcodeIO Thanks! :) |
No description provided.