Skip to content

Fix Array's & String function methods and avoid buffer caching #415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jan 17, 2019
Merged

Fix Array's & String function methods and avoid buffer caching #415

merged 8 commits into from
Jan 17, 2019

Conversation

MaxGraey
Copy link
Member

Relate #408

@MaxGraey MaxGraey changed the title Fix function methods and avoid buffer caching Fix Array's function methods and avoid buffer caching Jan 11, 2019
@MaxGraey MaxGraey requested a review from dcodeIO January 11, 2019 16:21
dcodeIO
dcodeIO approved these changes Jan 11, 2019
View reviewed changes
Copy link
Member

@dcodeIO dcodeIO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MaxGraey MaxGraey changed the title Fix Array's function methods and avoid buffer caching Fix Array's & String function methods and avoid buffer caching Jan 13, 2019
@dcodeIO
Copy link
Member

dcodeIO commented Jan 16, 2019

Looks like this conflicts with a previous PR now, sorry

@MaxGraey
Copy link
Member Author

Synced with master

@dcodeIO dcodeIO merged commit 54b02c2 into AssemblyScript:master Jan 17, 2019
@dcodeIO
Copy link
Member

dcodeIO commented Jan 17, 2019

Thanks! :)

@MaxGraey MaxGraey deleted the fix-realloc-functio-methods branch January 17, 2019 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcodeIO dcodeIO dcodeIO approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MaxGraey @dcodeIO