Skip to content

Improve decorator declarations #426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 24, 2019
Merged

Improve decorator declarations #426

merged 6 commits into from
Jan 24, 2019

Conversation

MaxGraey
Copy link
Member

@MaxGraey MaxGraey commented Jan 17, 2019

Try to eliminate "Cannot find global TypedPropertyDescriptor" error

@MaxGraey MaxGraey requested a review from dcodeIO January 17, 2019 19:36
@dcodeIO
Copy link
Member

dcodeIO commented Jan 18, 2019

So, I guess the entire declaration for those descriptors is necessary in the .d.ts, and we can't just use dummies (without any fields)?

@MaxGraey
Copy link
Member Author

MaxGraey commented Jan 18, 2019

May be. Hard to tell. I guess typescript's language service expect or reuse some of this definitions

@dcodeIO dcodeIO merged commit d709cf3 into AssemblyScript:master Jan 24, 2019
@dcodeIO
Copy link
Member

dcodeIO commented Jan 24, 2019

Thanks! :)

@MaxGraey MaxGraey deleted the improve-decorator-declarations branch January 24, 2019 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants