Skip to content

Implement sin / cos / tan for Mathf namespace only #491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 39 commits into from
Mar 5, 2019
Merged

Implement sin / cos / tan for Mathf namespace only #491

merged 39 commits into from
Mar 5, 2019

Conversation

MaxGraey
Copy link
Member

@MaxGraey MaxGraey commented Feb 16, 2019 •
edited by dcodeIO
Loading

DONE

  • Mathf.sin
  • Mathf.cos
  • Mathf.tan
  • Mathf.sincos
  • Add comments
  • More test vectors

Partially solves #58

@MaxGraey MaxGraey marked this pull request as ready for review February 18, 2019 12:52
@MaxGraey MaxGraey requested a review from dcodeIO February 18, 2019 12:54
@MaxGraey MaxGraey changed the title [WIP] Implement sin / cos / tan for Mathf namespace only Implement sin / cos / tan for Mathf namespace only Feb 18, 2019
dcodeIO
dcodeIO reviewed Feb 20, 2019
View reviewed changes
dcodeIO
dcodeIO reviewed Mar 1, 2019
View reviewed changes
dcodeIO
dcodeIO reviewed Mar 5, 2019
View reviewed changes
dcodeIO
dcodeIO reviewed Mar 5, 2019
View reviewed changes
dcodeIO
dcodeIO reviewed Mar 5, 2019
View reviewed changes
@dcodeIO dcodeIO merged commit 208dc2f into AssemblyScript:master Mar 5, 2019
@MaxGraey MaxGraey deleted the mathf-sin-cos-tan branch March 5, 2019 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcodeIO dcodeIO dcodeIO left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MaxGraey @dcodeIO