Skip to content

Implement TypedArray#forEach #530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 6, 2019
Merged

Implement TypedArray#forEach #530

merged 2 commits into from
Mar 6, 2019

Conversation

jtenner
Copy link
Contributor

@jtenner jtenner commented Mar 6, 2019

  • add test for forEach
    • test values against forEachValues array
    • test index against call count
    • test self parameter against cached pointer
    • test final callback count
  • update d.ts file
  • implement macro FOREACH in internal/typedarray.ts
  • implement prototype method on each class in typedarray.ts

@dcodeIO dcodeIO requested a review from MaxGraey March 6, 2019 17:38
MaxGraey
MaxGraey approved these changes Mar 6, 2019
View reviewed changes
Copy link
Member

@MaxGraey MaxGraey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dcodeIO dcodeIO merged commit 783dd32 into AssemblyScript:master Mar 6, 2019
@dcodeIO
Copy link
Member

dcodeIO commented Mar 6, 2019

Thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxGraey MaxGraey MaxGraey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jtenner @dcodeIO @MaxGraey