Use lazy initializations for decorators and type parameters in parser #554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxGraey
changed the title
dcodeIO
reviewed
Mar 21, 2019
dcodeIO
reviewed
Mar 21, 2019
dcodeIO
reviewed
Mar 21, 2019
| @@ -939,7 +939,8 @@ export class Parser extends DiagnosticEmitter { | |||
|
|
|||
| // at '<': TypeParameter (',' TypeParameter)* '>' | |||
|
|
|||
| var typeParameters = new Array<TypeParameterNode>(); | |||
| // var typeParameters = new Array<TypeParameterNode>(); | |||
| var typeParameters: TypeParameterNode[] | null = null; | |||
There was a problem hiding this comment.
Now I'm wondering: If we are already at <, the usual case here is that we'll end up with an array and not null since <> is invalid. If we had the Array.create<TypeParameterNode>(1) helper I mentioned in the runtime PR (the one that would guarantee a backing buffer for at least one element but with length=0), that might make the most sense here as it avoids the (most of the time) redundant null check below. Wdyt?
There was a problem hiding this comment.
I think it could be even better. Reserve not 1 element but for example 8 when array is created. And this elements btw could store outside of buffer exactly inside Array class. Similar approach have SmallVector in binaryen and LLVM's SmallVector
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.