Skip to content

Simplify Array#splice. Improve array's tests #910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 18, 2019
Merged

Simplify Array#splice. Improve array's tests #910

merged 8 commits into from
Oct 18, 2019

Conversation

MaxGraey
Copy link
Member

No description provided.

@MaxGraey
Copy link
Member Author

MaxGraey commented Oct 15, 2019 •
edited
Loading

btw it seems checker trigger false positive warnings about

INFO AS210: Expression is never 'null'.

     assert(spliced2[0]!.v == 1);

INFO AS210: Expression is never 'null'.

     assert(refArr2[1]!.v == 2);

But spliced2 and refArr2 is actually has (Ref | null)[] type.

@MaxGraey MaxGraey requested a review from dcodeIO October 15, 2019 21:04
@dcodeIO dcodeIO merged commit 0bea37c into AssemblyScript:master Oct 18, 2019
@dcodeIO
Copy link
Member

dcodeIO commented Oct 18, 2019

Thanks :)

@MaxGraey MaxGraey deleted the unify-array-splice branch October 18, 2019 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcodeIO dcodeIO Awaiting requested review from dcodeIO

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MaxGraey @dcodeIO