Align loader API with WebAssembly API

[dcodeIO]

This makes loader.instantiate asynchronous to align with WebAssembly.instantiate and replaces loader.instantiateBuffer with loader.instantiateSync accepting both a pre-compiled module or a buffer, just like loader.instantiate.

[MaxGraey]

Could we also use instantiateStreaming if available inside loader.instantiate? so it will automatically choose best possible async way for loading without extra efforts from user

[dcodeIO]

I think so, if there is a proper check to determine that moduleOrBuffer is a Response object. Hesitated to do this because I noticed Response | PromiseLike<Response> below and wasn't sure if something like that is properly detectable?

[MaxGraey]

you mean something like isPromiseLike guard?

function isPromiseLike(p: any): p is PromiseLike {
  return !!p && p.then instanceof Function;
}

[dcodeIO]

The question I had in mind was "what if the argument is not directly a response, but a promise for a response - how can we differentiate that from a promise for something else?"

[MaxGraey]

You mean how detect is object is Promise (promise like) and this Promise contain Response object without resolving Promise? I guess it hard to detect. Better try resolve this promise and check arrayBuffer method for example

[dcodeIO]

Would then look like

async function instantiate(moduleOrBuffer, imports) {
  if (
    typeof Response !== "undefined" && (
      typeof moduleOrBuffer.then === "function" ||
      moduleOrBuffer instanceof Response
    )
  ) return instantiateStreaming(moduleOrBuffer, imports);
  return postInstantiate(
    preInstantiate(imports || (imports = {})),
    (await WebAssembly.instantiate(moduleOrBuffer, imports)).instance
  );
}

Hmm...

[MaxGraey]

LGTM