Enable publishing #942
Merged
Enable publishing #942
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
probably to |
|
Or that :) |
|
My guess so far is that npm publishing should work, but gpr fails for one of the following reasons:
Now, as chances are that at least npm will work, I think we can give this a try. |
|
Will know in about half an hour :). Or, wait... actually 2 1/2 hours?! Edit: Now it should be in 10 minutes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is what's necessary to enable publishing to npm and gpr. Unfortunately, whether this will work or not is hard to test, so I'm wondering if we should just merge it and see what happens. If anything goes wrong, we can still learn from it and update to 0.9.0 or something. Objections?