Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: run compiler tests on Windows #984

Merged
merged 3 commits into from Dec 2, 2019
Merged

CI: run compiler tests on Windows #984

merged 3 commits into from Dec 2, 2019

Conversation

jhwgh1968
Copy link
Contributor

@jhwgh1968 jhwgh1968 commented Dec 1, 2019

Tests the compiler on Windows as a separate CI job. This is designed to catch "bash-isms" that could otherwise sneak in, rather than provide full Windows coverage. Thus it only tests the stable node version.

On Linux, nvm is used to determine the current stable version. Since that does not work on Windows, the job uses nvm-windows as a substitute. That project is written in Golang, so a pre-compiled binary is downloaded and invoked directly.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@dcodeIO
Copy link
Member

dcodeIO commented Dec 1, 2019

LGTM, great to have this in CI. Just a minor comment above.

@dcodeIO dcodeIO merged commit 156dab9 into AssemblyScript:master Dec 2, 2019
@dcodeIO
Copy link
Member

dcodeIO commented Dec 2, 2019

Thanks!

@jhwgh1968 jhwgh1968 deleted the windows-ci branch December 15, 2019 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants