Skip to content

Conversation

InCogNiTo124
Copy link
Contributor

📑 Description

Adds https://github.com/idursun/jjui support to the jj astrocommunity pack

ℹ Additional Information

cc @Cretezy who created the original pack

Copy link

github-actions bot commented Jun 15, 2025

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Entry returns a single plugin spec with the new plugin as the only top level spec (not applicable for recipes or packs).

  • Proper usage of opts table rather than setting things up with the config function.

  • Proper usage of specs table for all specs that are not dependencies of a given plugin (not applicable for recipes or packs).

@Cretezy
Copy link
Contributor

Cretezy commented Jun 15, 2025

LGTM

@azdanov
Copy link
Contributor

azdanov commented Jun 17, 2025

Could you please update the README also and add the new keymap there

Copy link
Contributor

@azdanov azdanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@azdanov azdanov merged commit 219e54c into AstroNvim:main Jun 18, 2025
16 checks passed
@InCogNiTo124 InCogNiTo124 deleted the feature/jjui branch June 18, 2025 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants