fix: always return 200 for session endpoint #130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katlyn
reviewed
Sep 2, 2024
Comment on lines
+8
to
+10
| if (session.user) { | ||
| await sessionHooks.callHookParallel('fetch', session as UserSessionRequired, event) | ||
| } |
There was a problem hiding this comment.
Is there a reason for requiring that user being defined on the session is required before running the fetch hook? This seems to be a breaking change, compared to the previous implementation. For my use case i would like the user property to be populated dynamically by a session hook based on other information in the session, but this change prevents that use case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #115