-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MERI plan version viewing #2980
Comments
Testing notes: As part of this testing I kept checking on the MERI plan comparison function (i.e. compares the current saved version to the last approved version and highlights additions in green and deletions in red). This worked fine for when I added new services and updated the targets (highlighted green). But didn’t pick up extra text I added in the project description field as part of the same set of updates (i.e. all done at the same time and saved at the same time). I think any changes to the description should be picked up by this function. I also tested to see if there were any other fields that weren’t getting picked up for any updates. There are: Project Title Circled updates didn’t appear in the ‘comparison’ doc (which is also attached). |
There are also issues with the rendering of the outcomes in some places: |
Hi @chrisala, the project name and description fields comparison are now fixed. |
And also the rendering of the outcome field. |
This appears to have broken stuff. The first symptom is the failing test in the DataSetSpec and the reason this is failing is the project name is being saved as an empty string when the MERI plan is saved. Need to revert this change. @salomon-j |
…the failing integration test(DatasetSpec) #2980
https://support.ehelp.edu.au/a/tickets/183605
Test Plan:
MERI plan version viewing
Expected results
The text was updated successfully, but these errors were encountered: