Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MERI plan version viewing #2980

Open
salomon-j opened this issue Aug 31, 2023 · 6 comments
Open

MERI plan version viewing #2980

salomon-j opened this issue Aug 31, 2023 · 6 comments
Assignees
Milestone

Comments

@salomon-j
Copy link
Contributor

salomon-j commented Aug 31, 2023

https://support.ehelp.edu.au/a/tickets/183605

Test Plan:
MERI plan version viewing

  • Find an existing RDP project. (this feature is only available for RDP projects)
  • Navigate to "Admin" → "MERI Plan" and press the "Show approval history" button and press "View Changes" button(fork icon) or press the "Compare with the latest approved MERI Plan" button.

Expected results

  • Each time the MERI plan has been approved there show be a row in the table.
  • Clicking on the icon in the "View Changes" column should open a copy of the marked-up MERI plan version that show the changes (if any) between the selected row in the table and the current MERI plan.
@salomon-j salomon-j self-assigned this Aug 31, 2023
@chrisala chrisala added this to the 3.1 milestone Sep 7, 2023
salomon-j added a commit that referenced this issue Sep 11, 2023
salomon-j added a commit that referenced this issue Sep 12, 2023
salomon-j added a commit that referenced this issue Sep 12, 2023
salomon-j added a commit that referenced this issue Sep 18, 2023
salomon-j added a commit that referenced this issue Sep 19, 2023
salomon-j added a commit that referenced this issue Sep 19, 2023
salomon-j added a commit that referenced this issue Sep 20, 2023
salomon-j added a commit that referenced this issue Sep 25, 2023
salomon-j added a commit that referenced this issue Sep 25, 2023
salomon-j added a commit that referenced this issue Sep 27, 2023
salomon-j added a commit that referenced this issue Oct 16, 2023
@chrisala
Copy link
Collaborator

chrisala commented Dec 15, 2023

Testing notes:

As part of this testing I kept checking on the MERI plan comparison function (i.e. compares the current saved version to the last approved version and highlights additions in green and deletions in red). This worked fine for when I added new services and updated the targets (highlighted green). But didn’t pick up extra text I added in the project description field as part of the same set of updates (i.e. all done at the same time and saved at the same time). I think any changes to the description should be picked up by this function.

I also tested to see if there were any other fields that weren’t getting picked up for any updates. There are:

Project Title
Project Description

Circled updates didn’t appear in the ‘comparison’ doc (which is also attached).

Image

@chrisala
Copy link
Collaborator

There are also issues with the rendering of the outcomes in some places:

Image

Image

(Ref: https://fieldcapture-test.ala.org.au/project/viewMeriPlanChanges/0d02b422-5bf7-495f-b9f2-fa0a3046937f)

@chrisala
Copy link
Collaborator

@salomon-j

@salomon-j
Copy link
Contributor Author

Hi @chrisala, the project name and description fields comparison are now fixed.
Screenshot 2023-12-15 at 3 30 21 pm

@salomon-j
Copy link
Contributor Author

And also the rendering of the outcome field.

@chrisala
Copy link
Collaborator

chrisala commented Dec 17, 2023

Hi @chrisala, the project name and description fields comparison are now fixed.

This appears to have broken stuff. The first symptom is the failing test in the DataSetSpec and the reason this is failing is the project name is being saved as an empty string when the MERI plan is saved. Need to revert this change. @salomon-j

salomon-j added a commit that referenced this issue Dec 18, 2023
salomon-j added a commit that referenced this issue Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants