Improve caching on dockerfiles (#4987)

Author: raymondjacobson

creator-node/Dockerfile

@@ -47,7 +47,6 @@ RUN echo 'http://mirror.leaseweb.com/alpine/v3.13/community' >> /etc/apk/reposit
     mkdir /usr/local/openresty/logs && \
     mkdir /usr/local/openresty/cache
 
-COPY nginx_conf /usr/local/openresty/conf/
 
 # Create a db user if postgres in case it will be run inside this container
 COPY scripts/init-db.sh scripts/init-db.sh
@@ -56,8 +55,7 @@ RUN bash scripts/init-db.sh
 COPY --from=builder /app/node_modules node_modules
 
 COPY . .
-
-RUN npm run postinstall
+COPY nginx_conf /usr/local/openresty/conf/
 
 # Compile js code to typescript based on tsconfig.build.json
 RUN ./node_modules/.bin/tsc --project tsconfig.build.json

discovery-provider/Dockerfile

@@ -57,19 +57,20 @@ RUN echo 'http://dl-cdn.alpinelinux.org/alpine/v3.10/main' >> /etc/apk/repositor
         postgresql-libs=11.12-r0 \
         postgresql=11.12-r0
 
-COPY nginx_conf /usr/local/openresty/conf/
-
-COPY scripts/init-db.sh scripts/init-db.sh
-RUN bash scripts/init-db.sh
 
 # Upgrade pip first to accomodate anchor.py installation
 COPY requirements.txt requirements.txt
 RUN python3 -m pip install --upgrade pip && python3 -m pip install -r requirements.txt --no-cache-dir
 
+COPY scripts/init-db.sh scripts/init-db.sh
+RUN bash scripts/init-db.sh
+
+COPY --from=contracts /usr/src/app/build/contracts/ build/contracts/
+
 COPY . .
 RUN --mount=type=cache,target=/root/.npm cd es-indexer && npm ci && npm run build
 
-COPY --from=contracts /usr/src/app/build/contracts/ build/contracts/
+COPY nginx_conf /usr/local/openresty/conf/
 
 # ARGs can be optionally defined with --build-arg while doing docker build eg in CI and then set to env vars
 ARG git_sha