Skip to content

Conversation

@sliptype
Copy link
Contributor

Description

  • Scroll position was resetting on history change. So need to wait until scroll end, remove the search param, and scroll to comment section without smooth

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.

@sliptype sliptype requested review from a team, DejayJD and dylanjeffers October 25, 2024 03:05
@changeset-bot
Copy link

changeset-bot bot commented Oct 25, 2024

⚠️ No Changeset found

Latest commit: f713304

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@sliptype sliptype enabled auto-merge (squash) October 25, 2024 03:13
@audius-infra
Copy link
Collaborator

Preview this change https://demo.audius.co/sk-c-5286-show-comments-scroll

@sliptype sliptype disabled auto-merge October 25, 2024 03:25
@sliptype sliptype merged commit 2957e45 into main Oct 25, 2024
7 checks passed
@sliptype sliptype deleted the sk-c-5286-show-comments-scroll branch October 25, 2024 03:25
audius-infra pushed a commit that referenced this pull request Oct 26, 2024
[68ad1bc] [QA-1785] Fix remixes missing view all button (#10235) Raymond Jacobson
[6330686] fix padding for duration minutes (#10237) Andrew Mendelsohn
[ee08499] [C-5304] Fix text clipping on mobile due to emojis (#10233) JD Francis
[a6dd2b7] [C-5292] Add comment reaction notification setting (#10220) Dylan Jeffers
[81f4aae] [QA-1787, QA-1786] Fix offline collections filtering and playback (#10229) Andrew Mendelsohn
[c87aa36] Fix notification linking and comment reaction notifications (#10232) Dylan Jeffers
[967a656] Fix DM render loop (#10230) Raymond Jacobson
[4fec2cc] [C-5300] Fix import in UserGeneratedTextV2 to fix link unfurls (#10231) Kyle Shanks
[0fb9136] [QA-1549] Fix offline collection downloads (#10204) Andrew Mendelsohn
[4b7b5e8] Truncate followee reposts and saves in TrackTile (#10227) Sebastian Klingler
[1565a01] Fix timestamp formatter + mood emoji alignment (#10226) Andrew Mendelsohn
[0200ccd] [C-5237] Fix ComposerInput height (#10225) Kyle Shanks
[5465a83] [C-5239] Fix horizontal overflow in composer input (#10224) Kyle Shanks
[a01d5fa] [C-5162] Fix comment mute overflow position (#10217) Dylan Jeffers
[70ef540] [C-5103] Add toast for deleted comments (#10215) Dylan Jeffers
[4d71fa1] [C-5253] Fix muted comments not showing up on profile page (#10214) Dylan Jeffers
[6cc2326] [C-5289] Turn off search analytics for autocomplete (#10213) Dylan Jeffers
[78cc2b3] [C-5231] Prevent images from being draggable (#10218) Dylan Jeffers
[09ee757] [C-5126] Add divider for disable comments field (#10216) Dylan Jeffers
[6e52f74] [C-5236] Add keyboard navigation for user mentions autocomplete (#10183) Dylan Jeffers
[6b36bca] [C-5131] Update comment notification text for artist engagement (#10182) Dylan Jeffers
[6201627] Harmonize text selection color (#10211) Raymond Jacobson
[c33b4da] [C-5287] Require an account to reply to/flag comments (#10210) Raymond Jacobson
[1a2d701] [C-5275] Fix react dupe key error in notifs (#10199) Raymond Jacobson
[819706f] Small comment count fix (#10208) JD Francis
[2957e45] [C-5286] Fix removing showComments from url (#10207) Sebastian Klingler
samgutentag pushed a commit that referenced this pull request Nov 1, 2024
[68ad1bc] [QA-1785] Fix remixes missing view all button (#10235) Raymond Jacobson
[6330686] fix padding for duration minutes (#10237) Andrew Mendelsohn
[ee08499] [C-5304] Fix text clipping on mobile due to emojis (#10233) JD Francis
[a6dd2b7] [C-5292] Add comment reaction notification setting (#10220) Dylan Jeffers
[81f4aae] [QA-1787, QA-1786] Fix offline collections filtering and playback (#10229) Andrew Mendelsohn
[c87aa36] Fix notification linking and comment reaction notifications (#10232) Dylan Jeffers
[967a656] Fix DM render loop (#10230) Raymond Jacobson
[4fec2cc] [C-5300] Fix import in UserGeneratedTextV2 to fix link unfurls (#10231) Kyle Shanks
[0fb9136] [QA-1549] Fix offline collection downloads (#10204) Andrew Mendelsohn
[4b7b5e8] Truncate followee reposts and saves in TrackTile (#10227) Sebastian Klingler
[1565a01] Fix timestamp formatter + mood emoji alignment (#10226) Andrew Mendelsohn
[0200ccd] [C-5237] Fix ComposerInput height (#10225) Kyle Shanks
[5465a83] [C-5239] Fix horizontal overflow in composer input (#10224) Kyle Shanks
[a01d5fa] [C-5162] Fix comment mute overflow position (#10217) Dylan Jeffers
[70ef540] [C-5103] Add toast for deleted comments (#10215) Dylan Jeffers
[4d71fa1] [C-5253] Fix muted comments not showing up on profile page (#10214) Dylan Jeffers
[6cc2326] [C-5289] Turn off search analytics for autocomplete (#10213) Dylan Jeffers
[78cc2b3] [C-5231] Prevent images from being draggable (#10218) Dylan Jeffers
[09ee757] [C-5126] Add divider for disable comments field (#10216) Dylan Jeffers
[6e52f74] [C-5236] Add keyboard navigation for user mentions autocomplete (#10183) Dylan Jeffers
[6b36bca] [C-5131] Update comment notification text for artist engagement (#10182) Dylan Jeffers
[6201627] Harmonize text selection color (#10211) Raymond Jacobson
[c33b4da] [C-5287] Require an account to reply to/flag comments (#10210) Raymond Jacobson
[1a2d701] [C-5275] Fix react dupe key error in notifs (#10199) Raymond Jacobson
[819706f] Small comment count fix (#10208) JD Francis
[2957e45] [C-5286] Fix removing showComments from url (#10207) Sebastian Klingler
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants