Skip to content

Conversation

@raymondjacobson
Copy link
Member

Description

Needed to migrate existing client usage off of AudiusBackend & non /v1/ routes for playlists

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.

npm run protocol

http://audius-protocol-discovery-provider-1/v1/users/Yo1kR0J/playlists
http://audius-protocol-discovery-provider-1/v1/full/users/Yo1kR0J/playlists

http://audius-protocol-discovery-provider-1/v1/users/Yo1kR0J/albums
http://audius-protocol-discovery-provider-1/v1/full/users/Yo1kR0J/albums

  • minor unit test addition

@changeset-bot
Copy link

changeset-bot bot commented Nov 9, 2024

🦋 Changeset detected

Latest commit: 099261c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@audius/sdk Minor
@audius/sdk-legacy Patch
@audius/sp-actions Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

)
playlists = get_playlists(args)

def format_playlist(playlist):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ick 😢

Could this happen inside of extend_playlist or no?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just copied what we did elsewhere... I'd be a little worried about changing the whole thing and breaking something else, but i can give it a go and test around

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nah i think be consistent is best

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually it's not so bad. i think it should be ok - i spot checked the other usages, and I think the marshaling will take care of what we need elsewhere where the activity_timestamps are used

@raymondjacobson raymondjacobson enabled auto-merge (squash) November 9, 2024 05:02
@raymondjacobson raymondjacobson merged commit 6322f3e into main Nov 9, 2024
9 checks passed
@raymondjacobson raymondjacobson deleted the rj-user-playlists-api branch November 9, 2024 05:13
audius-infra pushed a commit that referenced this pull request Nov 11, 2024
[e58d764] Fix free tracks not being allowed to be set as downloadable (#10414) Marcus Pasell
[b4864ab] Fix is_downloadable being set erroneously (#10413) Marcus Pasell
[6322f3e] Add discovery API + sdk support for for user playlists and albums (#10410) Raymond Jacobson
[44d18d9] sleep in core indexing (#10408) alecsavvy
[3ab16ce] Fix trending playlists (#10404) Marcus Pasell
[20e7fb3] [PAY-3574] Simplify chat unread count logic (#10396) Reed
[facbaca] Fix off-by-one error in fetching mirrors (#10401) Marcus Pasell
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants