-
Notifications
You must be signed in to change notification settings - Fork 123
Add discovery API + sdk support for for user playlists and albums #10410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 099261c The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| ) | ||
| playlists = get_playlists(args) | ||
|
|
||
| def format_playlist(playlist): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ick 😢
Could this happen inside of extend_playlist or no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just copied what we did elsewhere... I'd be a little worried about changing the whole thing and breaking something else, but i can give it a go and test around
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nah i think be consistent is best
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually it's not so bad. i think it should be ok - i spot checked the other usages, and I think the marshaling will take care of what we need elsewhere where the activity_timestamps are used
[e58d764] Fix free tracks not being allowed to be set as downloadable (#10414) Marcus Pasell [b4864ab] Fix is_downloadable being set erroneously (#10413) Marcus Pasell [6322f3e] Add discovery API + sdk support for for user playlists and albums (#10410) Raymond Jacobson [44d18d9] sleep in core indexing (#10408) alecsavvy [3ab16ce] Fix trending playlists (#10404) Marcus Pasell [20e7fb3] [PAY-3574] Simplify chat unread count logic (#10396) Reed [facbaca] Fix off-by-one error in fetching mirrors (#10401) Marcus Pasell
Description
Needed to migrate existing client usage off of AudiusBackend & non /v1/ routes for playlists
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.
http://audius-protocol-discovery-provider-1/v1/users/Yo1kR0J/playlists
http://audius-protocol-discovery-provider-1/v1/full/users/Yo1kR0J/playlists
http://audius-protocol-discovery-provider-1/v1/users/Yo1kR0J/albums
http://audius-protocol-discovery-provider-1/v1/full/users/Yo1kR0J/albums