Skip to content

Conversation

dylanjeffers
Copy link
Contributor

Description

Applies same optimization techniques from mobile lineup tiles to desktop. I found a few more areas where mobile was using inneficient hooks through this pass, so mobile should also get a decent additional speedup.

@changeset-bot
Copy link

changeset-bot bot commented Dec 4, 2024

⚠️ No Changeset found

Latest commit: 25e82d0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dylanjeffers dylanjeffers requested review from a team, isaacsolo and schottra and removed request for a team December 4, 2024 16:42
Copy link
Contributor

@amendelsohn amendelsohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sadge

great sleuthing though!

@dylanjeffers dylanjeffers merged commit 3652bb8 into main Dec 4, 2024
10 checks passed
@dylanjeffers dylanjeffers deleted the desktop-tile-perf branch December 4, 2024 19:55
dylanjeffers added a commit that referenced this pull request Dec 4, 2024
audius-infra pushed a commit that referenced this pull request Dec 7, 2024
[94850b5] Migrate getWaudioBalance to sdk + remove getSolanaConnection (#10635) Reed
[5ba5712] Upgrade something went wrong page error level (#10647) JD Francis
[1e58993] [QA-1873] Add back cache subscribe so UIDs get set correctly for playlists (#10646) Sebastian Klingler
[a9f910a] Finalize harmony theme v2 (#10644) Dylan Jeffers
[50f0e7a] Upgrade mobile apps to v1.1.128 (#10642) Dylan Jeffers
[494b2e8] Correct rewards page collectibles gating (#10600) Raymond Jacobson
[0fc1fbe] [C-5477] Guard against empty response from storage node (#10627) Andrew Mendelsohn
[52942a4] Remove getRandomFeePayer (#10636) Reed
[667b47f] Improve mobile entity collection screen loading (#10625) Dylan Jeffers
[de8a5bc] [C-5472] Refactor message drawers to use common drawers (#10610) Dylan Jeffers
[f092e9b] [PAY-3634] Move updateCreator to sdk (#10631) Raymond Jacobson
[b7b38ba] ⚠ AudiusWalletClient, Ethereum Contracts, Eth Relay, Service Renames (#10540) Marcus Pasell
[a5f3d89] Remove getUserEmail from libs Account (#10632) Reed
[c545347] [PAY-2936] Move notification writes to sdk (#10629) Raymond Jacobson
[4755d18] Two small cleanups (#10608) Reed
[8772a79] Setup backend on sdk signup (#10626) Isaac Solo
[3a989d3] Finalize image cleanup (#10599) Raymond Jacobson
[4fd1fb7] Reduce code dupe, add spinner, fix performance on profile collections (#10628) Raymond Jacobson
[734ffe6] Fix mobile upload image input missing (#10624) Andrew Mendelsohn
[12a973d] Fix track audio replace edits (#10622) Kyle Shanks
[a87463e] Fix invalid playlist fetching (#10623) Raymond Jacobson
[63549b9] update a missed updateCreator call with new signature (#10620) Randy Schott
[88ab378] Fix gated-content-access hooks (#10618) Dylan Jeffers
[8663f02] Fix signup error due to missing yield statement (#10617) Randy Schott
[a184d58] [C-5463] Tags and name updates for upload errors (#10591) Andrew Mendelsohn
[600c424] [C-5475] Update mobile track replace previews to use video lib (#10616) Kyle Shanks
[f959f9b] [C-5468, C-5470] Update downloads for file-replace (#10614) Kyle Shanks
[dd9ad53] Fix typo (#10615) Raymond Jacobson
[9194d68] [C-5471] Re-land react native 0.75 (#10609) Dylan Jeffers
[0b6f6b1] [PAY-3619] Remove libs dependency for collectibles/assoc wallets (#10603) Raymond Jacobson
[b8d09ab] ⚠️ [PAY-3586] Migrate upload to sdk (#10541) Sebastian Klingler
[7f603c9] Sign Up Hardening Collection 1 (#10570) JD Francis
[993c856] [PAY-3633] Migrate getUserListenCountsMonthly to sdk (#10604) Reed
[389a894] [PAY-3629] Migrate get/changeUserEmail to identity service (#10583) Reed
[152978f] [C-5469] Fix repost avatar-list spacing (#10605) Dylan Jeffers
[e3c937e] Update dapp-store build artifacts audius-infra
[f6f7cf0] [C-5454] Add mobile web guest checkout flow (#10595) Dylan Jeffers
[00af19d] Fix artist dashboard page (#10602) Reed
[7e23674] [PAY-3636] Migrate getSignature to sdk (#10601) Reed
[c262478] [C-5461] Add small sound library and update preview context to play previews for file replace (#10597) Kyle Shanks
[140e92a] [PAY-3571] Use new image components in mobile (#10581) Raymond Jacobson
[5a04ba4] [C-5457] Replace rive with lottie (#10586) Dylan Jeffers
[1366de8] [C-5413, C-5415] Add FileReplace to the mobile edit track flow (#10596) Kyle Shanks
[9dc469f] Fix src imports leading to web type errors (#10594) Dylan Jeffers
[9ed2bb9] [C-5387] Complete sign up for guest accounts (#10566) Isaac Solo
[ea92262] Adds guards to bulk fetching hooks (#10592) Randy Schott
[3652bb8] Improve desktop track tile perf (#10588) Dylan Jeffers
[db17b91] [PAY-3631] Migrate sub/unsubscribe to user to sdk (#10585) Reed
[a60d521] [PAY-3630] Migrate resetPassword to authService (#10584) Reed
[886a11d] Remove unneeded waitForLibsInit (#10582) Reed
[8098722] [PAY-3579] Migrate signup to SDK (#10539) Randy Schott
[cae7c82] [C-5462] Fix EditTrackForm download function (#10579) Kyle Shanks
[a5fe205] [C-5412, C-5414] Add file replace functionality to mobile upload flow (#10576) Kyle Shanks
[b3d902b] Convert get mutuals to sdk (#10575) Reed
[472ed2e] Simplify cache feature flags (#10558) Dylan Jeffers
[fda883f] Convert follow/unfollow to sdk (#10574) Reed
[03cf2f7] [C-5448] Add isGuest column to identity users (#10552) Isaac Solo
[1915ddf] Add remote config value for sentry replay recording (#10569) JD Francis
[2638d36] [PAY-3625] Add feature flag to use csv function conditionally (#10567) Farid Salau
[dd3f79a] Convert SettingsPageProvider to functional component (#10562) Reed
[13e4144] Navigate to trending after signout (#10565) Reed
[0cd5c94] [PAY-3602] Add CSV export function (#10547) Farid Salau
[0fff598] [QA-1856] Fix mobile uploads hanging infinitely (#10549) JD Francis
[31c266e] Fix common tests due to feature flag removals (#10563) Dylan Jeffers
[54a66d2] [C-5451] Harmony theme v2 QA (#10556) Dylan Jeffers
[deca8c0] [C-5449] Fix track tile performance (#10553) Dylan Jeffers
[f4d6653] Convert UserList to functional component (#10555) Reed
[b10582c] Remove simple feature flags (#10561) Dylan Jeffers
[a93c986] Remove editable-access feature flag (#10560) Dylan Jeffers
[bd15119] Remove hidden-paid-scheduled flag (#10559) Dylan Jeffers
[8b4b8dd] Remove various feature flags (#10557) Dylan Jeffers
[9cd8f09] [C-5450] Add theme v2 compat for legacy mobile theme (#10554) Dylan Jeffers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants