Fix trending aSPET inconsistency with old trending #2019
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Edge cases for trending version
aSPETnot matchingePWJD.Two bugs:
1.) Previously we were getting the diff in days in python as follows:
which gets the total diff in days, seconds, milliseconds and we take the day part off it.
In the updated postgres version, we get the diff by running
(now()::date - aip.created_at::date)which gets the actual dates and subtracts the day part of it ie. 09/25/2021 - 09/21/2021 => 4 daysThe previous case takes into consideration elapsed time, so if 24 hours past it counts as a day while the postgres method only takes into consideration the date.
To fix this, the day diff is not calculated using
EXTRACT(DAYS from now() - aip.created_at)2.) When fetching tracks to cache into the top trending, the selected tracks to score are the top most played in that time range. The net multiplier was not used in selecting the tracks in the new mat view method.
Tests
Serval scripts were written to compare the results from the two trending methods
How will this change be monitored?
manually