Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gallery block: images don't scale vertically in emails #33798

Closed
simison opened this issue Oct 26, 2023 · 10 comments
Closed

Gallery block: images don't scale vertically in emails #33798

simison opened this issue Oct 26, 2023 · 10 comments
Labels
[Feature] Subscriptions All subscription-related things such as paid and unpaid, user management, and newsletter settings. [Platform] Atomic [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] Normal [Type] Bug When a feature is broken and / or not performing as intended

Comments

@simison
Copy link
Member

simison commented Oct 26, 2023

Impacted plugin

Jetpack

Quick summary

When adding images via core gallery block, the images scale well to screen size in desktop.

In the email images scale only horizontally, not vertically.

Example post. User report.

Desktop

Screen.Recording.2023-10-26.at.10.34.27.mov

Email

image

Reported at p1698133168065399-slack-C02NQ4HMJKV

Steps to reproduce

A clear and concise description of what you expected to happen.

No response

What actually happened

No response

Impact

All

Available workarounds?

No but the platform is still usable

Platform (Simple and/or Atomic)

Atomic

Logs or notes

No response

@simison simison added [Type] Bug When a feature is broken and / or not performing as intended Needs triage Ticket needs to be triaged labels Oct 26, 2023
@github-actions github-actions bot added [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Platform] Atomic [Pri] High [Status] Priority Review Triggered The guild in charge of triage has been notified of this issue in Slack labels Oct 26, 2023
@sunipeyk
Copy link

Thank you @simison. And a little advice/request for those whom writing the codes; please avoid using inline css. It's a terrible idea. Thank you again.

@sunipeyk
Copy link

sunipeyk commented Oct 26, 2023

The description of the problem is incorrect/ and/or incomplete. note: I think I explained the situation more clearly in my comments below.

@jeherve jeherve added [Feature] Subscriptions All subscription-related things such as paid and unpaid, user management, and newsletter settings. [Pri] Normal and removed [Pri] High [Status] Priority Review Triggered The guild in charge of triage has been notified of this issue in Slack Needs triage Ticket needs to be triaged labels Oct 26, 2023
@jeherve jeherve moved this from Needs Triage to Triaged in Automattic Prioritization: The One Board ™ Oct 26, 2023
@sunipeyk
Copy link

sunipeyk commented Nov 3, 2023

I reviewed an older post of mine. ( sep, 18 2023) The inline css of the images of that post email is normal, as expected. However, those images were not deformed. The problem was not with the width:46% used inline. For your information.
And let me add one more thing. When I look at the problematic e-mails on iPhone, single images in the text are problematic, too. I think there was a problem after the date I gave above and it continues.

@sunipeyk
Copy link

sunipeyk commented Nov 3, 2023

Hello again, It is clearly seen that the required for the image to be responsive "height : auto;" is not included in the relevant inline css code.
If you don't want to use "height : auto;" in inline css code , you must not use "...<img width="500" height="650" src..." ( the bolds that width and height ) either. Those ruins the responsiveness of images. For your information.

@sunipeyk
Copy link

5 months have passed and no one is doing anything. Great, really great!

@sunipeyk
Copy link

sunipeyk commented Apr 5, 2024

You did not fix this problem in version 6.5. I wonder why? Anyway, I give up, no one cares anyway.

@Potato3142
Copy link

I seem to have this or a similar problem. Images in email are being squeezed vertically

@simison
Copy link
Member Author

simison commented May 30, 2024

Update here: we deployed some changes to email rendering images in D147624-code (internal reference), external reference but the issue here needs additional checks likely. cc @Automattic/zap

@simison
Copy link
Member Author

simison commented Jul 30, 2024

With some work done for this and no further reports here, I'm moving future similar problems to separate issues.

@Potato3142
Copy link

With some work done for this and no further reports here, I'm moving future similar problems to separate issues.

It's not fixed, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Subscriptions All subscription-related things such as paid and unpaid, user management, and newsletter settings. [Platform] Atomic [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] Normal [Type] Bug When a feature is broken and / or not performing as intended
Development

No branches or pull requests

4 participants