-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Social Icons from Social Logos Repo #18563
Conversation
Caution: This PR has changes that must be merged to WordPress.com |
Scheduled Jetpack release: February 2, 2021. Thank you for the great PR description! When this PR is ready for review, please apply the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Separately, once this and https://github.com/Automattic/social-logos/issues/92 lands, we should look at making social-logos into a Composer package.
With a composer.json
file and having it added to Packagist, we can set it up so the only extra thing needed is to tag in GitHub in addition to npm. Should be able to do it so only the needed files for PHP are included.
For reference: #13708 |
r220238-wpcom |
Fixes #13765
Fixes #10663
Changes proposed in this Pull Request:
Jetpack product discussion
N/a
Does this pull request change what data or activity we track or use?
Nope, don't think so.
Testing instructions:
Testing the Social Icons Widget:
Testing the Social Menu
Proposed changelog entry for your changes: