Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Social Icons from Social Logos Repo #18563

Merged
merged 8 commits into from
Jan 28, 2021
Merged

Conversation

sdixon194
Copy link
Contributor

@sdixon194 sdixon194 commented Jan 27, 2021

Fixes #13765
Fixes #10663

Changes proposed in this Pull Request:

Jetpack product discussion

N/a

Does this pull request change what data or activity we track or use?

Nope, don't think so.

Testing instructions:

Testing the Social Icons Widget:

  • Open the customizer
  • Add a social icons widget
  • Add urls for the new icons in question, e.g.:
    • blogger.com, blogspot.com
    • eventbrite.com
    • ghost.org
    • tiktok.com
    • woocommerce.com
    • xanga.com
  • You should see the logos appear in the widget area

Screen Shot 2021-01-27 at 13 19 50

Testing the Social Menu

  • Activate a theme that supports Jetpack social icons (e.g. Dara).
  • Open the customizer and add/edit the social menu.
  • Add urls for the new icons in question
  • You should see the logos appear in the social media menu.

social menu change

Proposed changelog entry for your changes:

  • Social Icons Widget: Adds Blogger, Eventbrite, Ghost, Tiktok, WhatsApp, WooCommerce and Xanga icons for social icons widget and social menus utilizing Jetpack's social icons.

@sdixon194 sdixon194 added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] Extra Sidebar Widgets [Feature] Theme Tools [Status] Needs Review To request a review from Crew. Label will be renamed soon. Touches WP.com Files labels Jan 27, 2021
@sdixon194 sdixon194 self-assigned this Jan 27, 2021
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello sdixon194! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D56093-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

@jetpackbot
Copy link

Scheduled Jetpack release: February 2, 2021.
Scheduled code freeze: January 25, 2021

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Generated by 🚫 dangerJS against 97f4dfa

Copy link
Contributor

@kraftbj kraftbj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Separately, once this and https://github.com/Automattic/social-logos/issues/92 lands, we should look at making social-logos into a Composer package.

With a composer.json file and having it added to Packagist, we can set it up so the only extra thing needed is to tag in GitHub in addition to npm. Should be able to do it so only the needed files for PHP are included.

@jeherve
Copy link
Member

jeherve commented Jan 28, 2021

we should look at making social-logos into a Composer package

For reference: #13708

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Jan 28, 2021
@kraftbj kraftbj merged commit 68ffaa3 into master Jan 28, 2021
@kraftbj kraftbj deleted the add/social-icon-repo-parity branch January 28, 2021 22:03
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Jan 28, 2021
@jeherve
Copy link
Member

jeherve commented Jan 29, 2021

r220238-wpcom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Extra Sidebar Widgets [Feature] Theme Tools Touches WP.com Files [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Social Menu & Social Media Icons: Add TikTok Support Social Menu & Social Media Icons: Add Whatsapp Support
5 participants