Photon: made the downsize filter return resulting image dimensions. #3029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zinigor
added
[Type] Enhancement
zinigor
added
[Status] In Progress
[Status] Needs Review
…have either a height or width assigned.
|
Tested in 2011, 2015, 2016. 💛 |
|
This works well in all of our local tests. It looks good, fixes an old 2011 theme issue, and makes post thumbnails responsive with 4.4. Let's get it into beta with a broader audience. |
dereksmart
added a commit
that referenced
this pull request
Nov 18, 2015
Photon: made the downsize filter return resulting image dimensions.
dereksmart
removed
the
[Status] Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to fix #2919 we needed to return image dimensions from the
filter_image_downsizefunction. This PR does this by returning the resulting dimensions that are sent to Photon for processing.