Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetpack AI: open upgrade path on new tab, part 1 #37457

Merged
merged 5 commits into from
May 21, 2024

Conversation

lhkowalski
Copy link
Contributor

@lhkowalski lhkowalski commented May 20, 2024

Part of #37458.

This change will make the upgrade button from the usage panel opens on a new tab instead of redirecting the editor tab.

Proposed changes:

  • Change target of buttons and links to _blank
  • Remove calls to autoSaveAndRedirect hook

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • run this branch on a fresh JN site
  • connect Jetpack then go to the block editor
  • enable debug messages by running localStorage.setItem( 'debug', '*' ); on the console
  • look for the AI Assistant section on the "Post" tab of the Settings sidebar
  • look for the "Available Requests" section:
Screenshot 2024-05-20 at 17 51 48
  • click the "Upgrade" button
  • confirm it opens the upgrade flow on a new tab
  • on the editor tab, confirm the tracking event was fired as expected:
Screenshot 2024-05-20 at 17 53 14
  • proceed with the upgrade flow on the new tab, buy the plan using credits
  • go back to the editor tab and refresh the page to get the new plan info
  • follow the same procedure to buy the other tiers, confirming that
    • it opens on a new tab
    • the tracking event is fired as before
  • follow the same procedure on the last tier, when the button changes to "Contact Us", confirming that
    • it opens on a new tab
    • the tracking event is fired as before

@lhkowalski lhkowalski self-assigned this May 20, 2024
@lhkowalski lhkowalski requested a review from a team May 20, 2024 19:29
@lhkowalski lhkowalski added the [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ label May 20, 2024
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.


Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen daily.
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly. The next release is scheduled for June 4, 2024 (scheduled code freeze on June 3, 2024).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Copy link
Contributor

github-actions bot commented May 20, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/jetpack-ai-open-upgrade-path-on-new-tab branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack update/jetpack-ai-open-upgrade-path-on-new-tab
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@lhkowalski lhkowalski changed the title Jetpack AI: open upgrade path on new tab Jetpack AI: open upgrade path on new tab, part 1 May 20, 2024
@lhkowalski lhkowalski marked this pull request as ready for review May 20, 2024 20:55
Copy link
Contributor

@dhasilva dhasilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhkowalski lhkowalski merged commit 4904cda into trunk May 21, 2024
60 checks passed
@lhkowalski lhkowalski deleted the update/jetpack-ai-open-upgrade-path-on-new-tab branch May 21, 2024 14:01
@github-actions github-actions bot added this to the jetpack/13.5 milestone May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Extension] AI Assistant Plugin [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants