-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Stats link for Atomic Classic sites #38013
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped. Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
'path' => $post_id, | ||
) | ||
); | ||
$stats_post_url = admin_url( sprintf( 'admin.php?page=stats#!/stats/post/%d/%d', $post_id, Jetpack_Options::get_option( 'id', 0 ) ) ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we check the admin interface style here? If we're on Default admin style, then go to Posts, then switch to Classic (for that page only), then click on the stats link, we'll open wp-admin Jetpack Stats link which has no navigation on the left sidebar menu.
90b0189
to
3f08537
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
- ✔️ Atomic Classic: /wp-admin stats
- ✔️ Atomic Default: Calypso Stats
- ✔️ Atomic Default with that particular page set to Classic view: Calypso Stats
- ✔️ Jetpack Sites: /wp-admin stats
Fixes https://github.com/Automattic/dotcom-forge/issues/7912
Proposed changes:
Before
Atomic sites point to Calypso Stats
After
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
No
Testing instructions: