Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Stats link for Atomic Classic sites #38013

Merged
merged 3 commits into from
Jun 25, 2024
Merged

Conversation

DustyReagan
Copy link
Member

@DustyReagan DustyReagan commented Jun 24, 2024

Fixes https://github.com/Automattic/dotcom-forge/issues/7912

Proposed changes:

Before

Atomic sites point to Calypso Stats

After

  • Atomic Classic: /wp-admin stats
  • Atomic Default: Calypso Stats
  • Atomic Default with that particular page set to Classic view: Calypso Stats
  • Jetpack Sites: /wp-admin stats

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • Use Jetpack Beta tester to check out to this branch
  • Test the behavior mentioned in Proposed changes
  • Test for Jetpack Sites
  • Make sure nothing on simple sites break, simple sites shouldn't be affected by the code in this PR

Copy link
Contributor

github-actions bot commented Jun 24, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the try/updating-stats-link branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack try/updating-stats-link
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added the [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ label Jun 24, 2024
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • 🔴 Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.


Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen daily.
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly. The next release is scheduled for July 2, 2024 (scheduled code freeze on July 1, 2024).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Jun 24, 2024
'path' => $post_id,
)
);
$stats_post_url = admin_url( sprintf( 'admin.php?page=stats#!/stats/post/%d/%d', $post_id, Jetpack_Options::get_option( 'id', 0 ) ) );
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we check the admin interface style here? If we're on Default admin style, then go to Posts, then switch to Classic (for that page only), then click on the stats link, we'll open wp-admin Jetpack Stats link which has no navigation on the left sidebar menu.

@candy02058912 candy02058912 changed the title Try/updating stats link Update Stats link for Atomic Classic sites Jun 25, 2024
@candy02058912 candy02058912 requested review from fushar and a team June 25, 2024 09:45
Copy link
Contributor

@lupus2k lupus2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

  • ✔️ Atomic Classic: /wp-admin stats
  • ✔️ Atomic Default: Calypso Stats
  • ✔️ Atomic Default with that particular page set to Classic view: Calypso Stats
  • ✔️ Jetpack Sites: /wp-admin stats

@lupus2k lupus2k merged commit 1f1cc10 into trunk Jun 25, 2024
56 checks passed
@lupus2k lupus2k deleted the try/updating-stats-link branch June 25, 2024 13:54
@github-actions github-actions bot removed the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Jun 25, 2024
@github-actions github-actions bot added this to the jetpack/13.6 milestone Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants