Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide login banner for agency managed sites #38021

Merged
merged 2 commits into from
Jun 25, 2024

Conversation

candy02058912
Copy link
Contributor

@candy02058912 candy02058912 commented Jun 25, 2024

Fixes https://github.com/Automattic/dotcom-forge/issues/7900

Proposed changes:

  • Agency sites with is_fully_managed_agency_site option should stay in /wp-admin, the login banner points to WP.com (Calypso), so we will hide the banner for agency-managed sites as discussed in he original issue.
Before After

Note

The agency managing the site will still be able to set the site visibility settings from their dashboard.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • With a WoA dev site, rsync the changes by following the Jetpack Rsync directions in pf4qpu-sv-p2
  • The site currently will show the banner
  • Run wp option update is_fully_managed_agency_site 1 for the site
  • The site should not show the banner

Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.


Wpcomsh plugin:

  • Next scheduled release: July 2, 2024.
  • Scheduled code freeze: June 24, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@candy02058912 candy02058912 marked this pull request as ready for review June 25, 2024 06:43
@candy02058912 candy02058912 changed the title Update/hide login banner for agency Hide login banner for agency managed sites Jun 25, 2024
Copy link
Contributor

@lupus2k lupus2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@lupus2k lupus2k force-pushed the update/hide-login-banner-for-agency branch from 50f6ad5 to d62394c Compare June 25, 2024 13:40
@lupus2k lupus2k merged commit c5b595d into trunk Jun 25, 2024
53 checks passed
@lupus2k lupus2k deleted the update/hide-login-banner-for-agency branch June 25, 2024 13:51
@github-actions github-actions bot added this to the wpcomsh/3.22.6 milestone Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants