Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Super cache - fix tempnam system directory warning #38028

Merged
merged 2 commits into from
Jun 25, 2024

Conversation

donnchawp
Copy link
Contributor

When WPSC is first installed it tries to create a temporary file when writing to the config file. As the cache directory hasn't been set up correctly yet, it can't, so it creates it in the system tmp directory. That results in a PHP warning. This PR fixes that by creating the cache directory first.

Fixes #

Proposed changes:

  • Call wp_cache_verify_cache_dir() before writing to the config file so the cache directory is there already.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Activate the plugin and you will see a warning, "tempnam(): file created in the system's temporary directory in..."
  • Apply this PR and deactivate and activate it and that warning won't show.

@donnchawp donnchawp added [Type] Bug When a feature is broken and / or not performing as intended [Status] Needs Team Review [Plugin] Super Cache A fast caching plugin for WordPress. labels Jun 25, 2024
@donnchawp donnchawp requested a review from a team June 25, 2024 11:10
@donnchawp donnchawp self-assigned this Jun 25, 2024
@donnchawp donnchawp changed the title Super cache/fix/tempnam system directory warning Super cache - fix tempnam system directory warning Jun 25, 2024
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.


Super Cache plugin:

  • Next scheduled release: July 2, 2024.
  • Scheduled code freeze: June 24, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Copy link
Member

@dilirity dilirity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No more notices, nice!

:shipit:

@dilirity dilirity merged commit 54de012 into trunk Jun 25, 2024
56 checks passed
@dilirity dilirity deleted the super-cache/fix/tempnam-system-directory-warning branch June 25, 2024 12:07
@github-actions github-actions bot added this to the super-cache/1.12.1 milestone Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Plugin] Super Cache A fast caching plugin for WordPress. [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants