Social: Remove unnecessary social connection feature checks

[manzoorwanijk]

Our feature checks are getting a bit unwieldy. Some like the Instagram connection have been launched for a year or more. We should remove the plugin version checks and other hacks so they're treated like any other feature. We can then remove the code from Jetpack, and eventually remove the feature entirely.

Proposed changes:

• Remove the unnecessary feature checks for social connections

Other information:

• Have you written new tests for your changes, if applicable?
• Have you checked the E2E test CI results, and verified that your changes do not break them?
• Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

• Go to connections management
• Confirm that you see Instagram, Nextdoor and Mastodon services just like any other services.
• Open social previews in the editor
• Confirm that you see Instagram, Nextdoor and Mastodon services just like any other services.

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

---

Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

---

Social plugin:

• Next scheduled release: August 6, 2024.
• Scheduled code freeze: July 29, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

[github-actions]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/remove-social-connection-feature-checks branch.

• To test on Simple, run the following command on your sandbox:

  bin/jetpack-downloader test jetpack update/remove-social-connection-feature-checks
  

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[gmjuhasz]

With this change I started seeing the Instagram notice on the adding page. It does not happen on trunk

[manzoorwanijk]

With this change I started seeing the Instagram notice on the adding page. It does not happen on trunk

Thanks. I have removed that notice.

[gmjuhasz]

I can confirm that the Instagram notice is not there anymore