Newsletters: Add Jetpack Newsletter Plugin Icon + Email Preview option.

[lezama]

Improves #38370

Proposed changes:

Other information:

Needs D157276-code

• Have you written new tests for your changes, if applicable?
• Have you checked the E2E test CI results, and verified that your changes do not break them?
• Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

• Check instructions in D157276-code

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

---

Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

---

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

• WordPress.com Simple releases happen daily.
• WoA releases happen weekly.
• Releases to self-hosted sites happen monthly. The next release is scheduled for none scheduled (scheduled code freeze on undefined).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

[github-actions]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the add/email-preview-endpoint branch.

• To test on Simple, run the following command on your sandbox:

  bin/jetpack-downloader test jetpack add/email-preview-endpoint
  

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[crisbusquets]

Hi @lezama !

I tested it using a Jurassic Ninja site, and I can see the "plugin" when I write a post:

The CTAs only seem to have rounded corners in one side. They all should be the same (the default)

The preview doesn't work, but I'm not sure if it's part of another PR. The error I see has to do with this:
{"code":"rest_cannot_send_email_preview","message":"Please connect your user account to WordPress.com","data":{"status":401}}

But I'm already connected to WordPress.com. If this is an error we expect would be quite common, we should add an alert in the plugin, right between the copy and the CTAs.

I see that the "plugin" also appears in Pages. Is it possible to remove it there? You'll never send a "Page" as a newsletter 🤔

[lezama]

thanks for the review @crisbusquets!

The CTAs only seem to have rounded corners in one side. They all should be the same (the default)

Great catch! fixed.

The preview doesn't work, but I'm not sure if it's part of another PR. The error I see has to do with this:

You need to set JETPACK__SANDBOX_DOMAIN to point to your sandbox with D157276-code applied, I will merge the wpcom side so it is easier to test!

But I'm already connected to WordPress.com. If this is an error we expect would be quite common, we should add an alert in the plugin, right between the copy and the CTAs.

We could! maybe change the icon if there's a problem?

I see that the "plugin" also appears in Pages. Is it possible to remove it there? You'll never send a "Page" as a newsletter 🤔

good point, fixed.

I added a feature flag, now you need to add ?showNewsletterMenu to the editor url to test this PR.

I think we could merge and improve on follow up PRs.

[crisbusquets]

Thanks @lezama!

I will merge the wpcom side so it is easier to test!

I'll wait for it 😅

[lezama]

I just deployed the wpcom side!

[lezama]

@crisbusquets deployed the wpcom side!

[simison]

Code looks good, let's merge behind feature flag and continue polishing 👍