-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Social: Add preview section to the social post modal #38686
Social: Add preview section to the social post modal #38686
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped. |
* Add connection toggle to the social post modal * Add changelog * Disable toggle when the connection is disabled * Disable tab if connection is disabled * Reduce opacity for disabled tabs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found that with FB we do not show the Visit the post for more.
text, the preview is just empty. That might be a different change but just making a note of that here
CleanShot.2024-08-02.at.15.12.05.png.mp4
Fixed. I think we should implement post template system ASAP at least for ourselves first to ensure we know what gets shared so that previews reflect the same. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works well now. Thanks.
Proposed changes:
useService
hook to easily get the service objectOther information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
define( 'JETPACK_SOCIAL_HAS_EDITOR_PREVIEW', true );