Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Social: Add preview section to the social post modal #38686

Merged
merged 11 commits into from
Aug 5, 2024

Conversation

manzoorwanijk
Copy link
Member

Proposed changes:

  • Extract some common logic to useService hook to easily get the service object
  • Add preview section to the social post modal

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Enable the editor preview feature - define( 'JETPACK_SOCIAL_HAS_EDITOR_PREVIEW', true );
  • Goto post editor
  • Open Jetpack or Social sidebar
  • Under "Share this post" section, click on "Create custom posts"
  • Confirm that you see the preview section in the modal
  • Confirm that the custom message and attached media are reflected correctly.
image

Copy link
Contributor

github-actions bot commented Aug 2, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the add/preview-section-to-the-social-post-modal branch.

    • For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.
  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack add/preview-section-to-the-social-post-modal
    
    bin/jetpack-downloader test jetpack-mu-wpcom-plugin add/preview-section-to-the-social-post-modal
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

Copy link
Contributor

github-actions bot commented Aug 2, 2024

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

* Add connection toggle to the social post modal

* Add changelog

* Disable toggle when the connection is disabled

* Disable tab if connection is disabled

* Reduce opacity for disabled tabs
Copy link
Contributor

@gmjuhasz gmjuhasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found that with FB we do not show the Visit the post for more. text, the preview is just empty. That might be a different change but just making a note of that here

CleanShot.2024-08-02.at.15.12.05.png.mp4

@manzoorwanijk
Copy link
Member Author

I found that with FB we do not show the Visit the post for more. text, the preview is just empty. That might be a different change but just making a note of that here

Fixed.

I think we should implement post template system ASAP at least for ourselves first to ensure we know what gets shared so that previews reflect the same.

Copy link
Contributor

@gmjuhasz gmjuhasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works well now. Thanks.

@manzoorwanijk manzoorwanijk merged commit 6c51520 into trunk Aug 5, 2024
72 checks passed
@manzoorwanijk manzoorwanijk deleted the add/preview-section-to-the-social-post-modal branch August 5, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants