Merge the changes in 2.7.1 upstream to master. #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In hindsight, looks like it was more confusing than helpful. Revert "Jetpack: Holiday Snow: Add an adminbar item of a snowflake if the user can control the snow being active, they are in wp-admin, and it is currently " This reverts commit 30fca55.
… them. Fixes some errors that have cropped up like: ``` Warning: require_once(/home/private/public_html/wp-content/plugins/jetpack/module s/featured-content/featured-content.php) [function.require-once]: failed to open stream: No such file or directory in /home/private/public_html/wp-content/plugins/jetpack/modules/theme-tools .php on line 54 ``` Introduced in 7a3e6bf205e08c2ffa4a2b4514f 6513a875c4d51
Add into theme-tools.php the ability to load a theme-compat file, and make it extensible so that themes or plugins can add or remove them.
Use class_exists() guard for Featured_Content. Necessary for wp-cli compatability, as wp-cli loads plugins -after- themes, as opposed to before like core does. Implementing this in theme-tools.php rather than theme-tools/featured-content.php so as to maintain the file integrity of featured-content.php against its wpcom variant. Props @tierra
georgestephanis
added a commit
that referenced
this pull request
Dec 17, 2013
Merge the changes in 2.7.1 upstream to master.
Merged
matticbot
pushed a commit
that referenced
this pull request
Dec 16, 2020
Summary: This MC page https://[private link]?tags=hello&sort=popularity&_locale=en&refresh=0 was failing with this error: ``` Fatal error: Uncaught Error: Call to undefined function has_meta() in /home/wpcom/public_html/public.api/rest/sal/class.json-api-post-base.php:123 Stack trace: #0 /home/wpcom/public_html/public.api/rest/json-endpoints/class.wpcom-json-api-post-v1-1-endpoint.php(264): SAL_Post->get_metadata() #1 /home/wpcom/public_html/public.api/rest/json-endpoints/class.wpcom-json-api-post-v1-1-endpoint.php(130): WPCOM_JSON_API_Post_v1_1_Endpoint->render_response_keys(Object(WPCOM_Post), 'display', Array) #2 /home/wpcom/public_html/public.api/rest/json-endpoints/class.wpcom-json-api-get-post-v1-1-endpoint.php(70): WPCOM_JSON_API_Post_v1_1_Endpoint->get_post_by('ID', 7265, 'display') #3 /home/wpcom/public_html/public.api/rest/wpcom-json-endpoints/class.wpcom-json-api-read-site-post-endpoint.php(35): WPCOM_JSON_API_Get_Post_v1_1_Endpoint->callback('/read/sites/%s/...', 131300129, 7265) #4 /home/wpcom/public_html/wp-content/lib/reader-site-post/class.wpcom-reader-site-post.php(23): WPCOM_JSON_API_Read_Site_Post_Endpoint->callback('/read/sites/%s/...', 131300129, 7265) #5 /home/wpcom/public_html/wp-content/rest-api-plugins/endpoints/read-tags-cards.php(214): WPCOM_Reader_Site_Post::get_site_post(131300129, 7265) #6 /home/wpcom/public_html/wp-content/rest-api-plugins/endpoints/read-tags-cards.php(180): WPCOM_REST_API_V2_Endpoint_Read_Tags_Cards->process_es_results(Array) #7 /home/missioncontrol/public_html/reader/mobile-endpoints/cards/index.php(95): WPCOM_REST_API_V2_Endpoint_Read_Tags_Cards->get_cards(Array) #8 {main} thrown in /home/wpcom/public_html/public.api/rest/sal/class.json-api-post-base.php on line 123 ``` Searching around, it seems that the `has_meta` function is defined not in `wp-includes/post.php` but rather in `wp-admin/includes/post.php` I am a bit skeptical of this change though, because it seems like it could be potentially breaking many things. Test Plan: Apply patch on sandbox and see that cards are properly working for: https://[private link]?tags=hello&sort=popularity&_locale=en&refresh=0 I feel like it needs a bunch more testing, but not sure exactly what. Will definitely need to make sure that it doesn't break other things. Reviewers: bluefuton, gibrown Reviewed By: gibrown Subscribers: vickikb, sodrowski, jsnmoon, gibrown Tags: #touches_jetpack_files Differential Revision: D53904-code This commit syncs r218377-wpcom.
jeherve
added a commit
that referenced
this pull request
Jun 18, 2021
* Add renovate.json * Add more configuration options Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: Jeremy Herve <jeremy@jeremy.hu>
leogermani
pushed a commit
that referenced
this pull request
Aug 12, 2022
When using WP-Cli to run the event "wp_cache_full_preload_hook" causes the follow error > /webdir/bin/wp cron event run --due-now ``` PHP Fatal error: Uncaught Error: Call to undefined function wp_cache_debug() in /webdir/web/app/plugins/wp-super-cache/wp-cache.php:3163 Stack trace: #0 /webdir/web/wp/wp-includes/class-wp-hook.php(298): wp_cron_preload_cache() #1 /webdir/web/wp/wp-includes/class-wp-hook.php(323): WP_Hook->apply_filters('', Array) #2 /webdir/web/wp/wp-includes/plugin.php(515): WP_Hook->do_action(Array) #3 phar:///webdir/bin/wp/php/commands/cron-event.php(284): do_action_ref_array('wp_cache_full_p...', Array) #4 phar:///webdir/bin/wp/php/commands/cron-event.php(255): Cron_Event_Command::run_event(Object(stdClass)) #5 [internal function]: Cron_Event_Command->run(Array, Array) #6 phar:///webdir/bin/wp/php/WP_CLI/Dispatcher/CommandFactory.php(67): call_user_func(Array, Array, Array) #7 [internal function]: WP_CLI\Dispatcher\CommandFactory::WP_CLI\Dispatcher\{closure}(Array, Array) #8 phar:///webdir/bin/wp/php/WP_CLI/Dispatcher/Subcommand.php(372): call_user_func(Objec in /webdir/web/app/plugins/wp-super-cache/wp-cache.php on line 3163 Fatal error: Uncaught Error: Call to undefined function wp_cache_debug() in /webdir/web/app/plugins/wp-super-cache/wp-cache.php:3163 Stack trace: #0 /webdir/web/wp/wp-includes/class-wp-hook.php(298): wp_cron_preload_cache() #1 /webdir/web/wp/wp-includes/class-wp-hook.php(323): WP_Hook->apply_filters('', Array) #2 /webdir/web/wp/wp-includes/plugin.php(515): WP_Hook->do_action(Array) #3 phar:///webdir/bin/wp/php/commands/cron-event.php(284): do_action_ref_array('wp_cache_full_p...', Array) #4 phar:///webdir/bin/wp/php/commands/cron-event.php(255): Cron_Event_Command::run_event(Object(stdClass)) #5 [internal function]: Cron_Event_Command->run(Array, Array) #6 phar:///webdir/bin/wp/php/WP_CLI/Dispatcher/CommandFactory.php(67): call_user_func(Array, Array, Array) #7 [internal function]: WP_CLI\Dispatcher\CommandFactory::WP_CLI\Dispatcher\{closure}(Array, Array) #8 phar:///webdir/bin/wp/php/WP_CLI/Dispatcher/Subcommand.php(372): call_user_func(Objec in /webdir/web/app/plugins/wp-super-cache/wp-cache.php on line 3163 ``` This patch correct this based on deactivate/uninstall hooks which works on WP-Cli.
3 tasks
3 tasks
Merged
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.