Sync: Add Jetpack Post Trashed event #6885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We current don't have a good way to track when the post is marked as trashed. Adding the jetpack_post_trashed event will let us know when we have post is marked as trashed.
enejb
added
[Package] Sync
[Status] Needs Review
lezama
reviewed
Apr 3, 2017
| @@ -238,14 +241,20 @@ function filter_post_content_and_add_links( $post_object ) { | |||
| } | |||
|
|
|||
| public function save_published( $new_status, $old_status, $post ) { | |||
| error_log( print_r( array( $new_status, $old_status ) ,1 )); | |||
lezama
reviewed
Apr 3, 2017
| wp_delete_post( $this->post->ID ); | ||
| $this->sender->do_sync(); | ||
|
|
||
| // Since the post status is not changing here we don't exect the post be trashed again. |
There was a problem hiding this comment.
exect the post be trashed again. => expect the post to be trashed again.
|
Nice work, left a couple of minor comments |
jeherve
added
[Team] Poseidon
[Status] Needs Author Reply
enejb
added
[Status] Needs Review
thingalon
approved these changes
Apr 6, 2017
thingalon
added
[Status] Ready to Merge
matticbot
removed
the
[Status] Ready to Merge
eliorivero
pushed a commit
that referenced
this pull request
Apr 25, 2017
* Changelog: initial commit for 4.9 release. * Changelog: add #6929 * Changelog: move old changelogs to changelog.txt * Readme: restore deleted release post link. The post is now live. * Changelog: add #6853 * Changelog: add #6856 * Changelog: add #6857 * Changelog: add #6884 * Changelog: add #6885 * Changelog: add #6892 * Changelog: add #6894 * Changelog: add #6898 * Changelog: add #6899 * Changelog: add #6900 * Changelog: add #6909 * Changelog: add #6927 * Changelog: add #6947 * Chagelog: add #6958 * Changelog: add #6961 * Changelog: add #6963 * Changelog: add #6965 * Changelog: add #6986 * Changelog: add #7000 * Changelog: add #7013 * Changelog: add #7015 * Changelog: add #7019 * Changelog: add #7028 * Changelog: add #6998 * Changelog: add #6999 * Changelog: add #7044 * Changelog: add #6881 * Changelog: add #6922 * Changelog: add #6940 * Changelog: add #6962 * Changelog: add #6942 * Changelog: add #6959 * Changelog: add #7018 * Changelog: add #6948 * Changelog: add #6657 * Changelog: add #7030 * Changelog: add #7048 * Changelog: add #7031 * Changelog: add #6990 * Changelog: add #6957 * Changelog: add #7027
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We current don't have a good way to track when the post is marked as
trashed.
The jetpack_post_trashed follows the same pattern as the published post event.
Changes proposed in this Pull Request:
post is marked as trashed.
Testing instructions: