Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings UI: auto-dismiss Jumpstart and other success notices #6898

Merged
merged 1 commit into from Apr 7, 2017
Merged

Settings UI: auto-dismiss Jumpstart and other success notices #6898

merged 1 commit into from Apr 7, 2017

Conversation

eliorivero
Copy link
Contributor

@eliorivero eliorivero commented Apr 4, 2017 •
edited

Changes proposed in this Pull Request:

  • dismiss notice shown after a process ends successfully like other success notices are dismissed:
    • Jumpstart
    • Reset options
    • Unlink user
  • solve minor ESLint notices

Testing instructions:

Jumpstart

  • Disconnect Jetpack
  • Reset options link in footer
  • Connect the site
  • Navigate back to the dashboard, you should see Jumpstart
  • Click 'Activate recommended features'
  • Once it ends, you should see a green success notice that should be automattically hidden after 2 seconds

Reset options

  • click the link Reset Options (dev only)
  • the green notice should be auto-dismissed

Unlink user

  • link a secondary user
  • unlink it. The green notice should be auto-dismissed

@eliorivero eliorivero added Admin Page React-powered dashboard under the Jetpack menu [Status] Needs Review To request a review from Crew. Label will be renamed soon. [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it labels Apr 4, 2017
@eliorivero eliorivero added this to the Settings UI milestone Apr 4, 2017
@eliorivero eliorivero self-assigned this Apr 4, 2017
@eliorivero eliorivero force-pushed the update/jumpstart-auto-dismiss-success-notice branch from abe2ca9 to d1f712c Compare April 4, 2017 18:25
@eliorivero eliorivero changed the title Settings UI: auto-dismiss Jumpstart success notice Settings UI: auto-dismiss Jumpstart and other success notices Apr 4, 2017
@eliorivero eliorivero requested a review from jeherve April 4, 2017 18:42
zinigor
zinigor approved these changes Apr 5, 2017
View reviewed changes
Copy link
Member

@zinigor zinigor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good, tests well!

@zinigor zinigor added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Apr 5, 2017
@eliorivero eliorivero modified the milestones: Settings UI, 4.8.1, 4.8.2 Apr 5, 2017
@jeherve jeherve removed this from the 4.8.2 milestone Apr 7, 2017
@dereksmart dereksmart merged commit baba4d7 into master Apr 7, 2017
@dereksmart dereksmart deleted the update/jumpstart-auto-dismiss-success-notice branch April 7, 2017 19:26
@dereksmart dereksmart removed the [Status] Ready to Merge Go ahead, you can push that green button! label Apr 7, 2017
jeherve added a commit that referenced this pull request Apr 24, 2017
@jeherve
Changelog: add #6898
c3adf5a
eliorivero pushed a commit that referenced this pull request Apr 25, 2017
@jeherve @eliorivero
Changelog: 4.9 release. (#6949)
07307cb 
* Changelog: initial commit for 4.9 release.

* Changelog: add #6929

* Changelog: move old changelogs to changelog.txt

* Readme: restore deleted release post link.

The post is now live.

* Changelog: add #6853

* Changelog: add #6856

* Changelog: add #6857

* Changelog: add #6884

* Changelog: add #6885

* Changelog: add #6892

* Changelog: add #6894

* Changelog: add #6898

* Changelog: add #6899

* Changelog: add #6900

* Changelog: add #6909

* Changelog: add #6927

* Changelog: add #6947

* Chagelog: add #6958

* Changelog: add #6961

* Changelog: add #6963

* Changelog: add #6965

* Changelog: add #6986

* Changelog: add #7000

* Changelog: add #7013

* Changelog: add #7015

* Changelog: add #7019

* Changelog: add #7028

* Changelog: add #6998

* Changelog: add #6999

* Changelog: add #7044

* Changelog: add #6881

* Changelog: add #6922

* Changelog: add #6940

* Changelog: add #6962

* Changelog: add #6942

* Changelog: add #6959

* Changelog: add #7018

* Changelog: add #6948

* Changelog: add #6657

* Changelog: add #7030

* Changelog: add #7048

* Changelog: add #7031

* Changelog: add #6990

* Changelog: add #6957

* Changelog: add #7027
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zinigor zinigor zinigor approved these changes

@dereksmart dereksmart Awaiting requested review from dereksmart

@jeherve jeherve Awaiting requested review from jeherve

Assignees

@eliorivero eliorivero

Labels
Admin Page React-powered dashboard under the Jetpack menu [Pri] High [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@eliorivero @zinigor @jeherve @dereksmart