Add listeners for comment approval and unapproval actions #6899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ner for Activity Log
Updated comment sync module test to check that the 'comment_approved_to_unapproved' action is fired/received when a comment is unapproved, and that it is only fired/received once.
…c module I'd added listeners to more comment related actions than I needed to in the comments sync module for the purpose of the Activity Log, and am removing them so that we only listen for the events/actions we need to.
enejb
reviewed
Apr 4, 2017
| @@ -47,6 +47,47 @@ public function test_update_comment() { | |||
| $this->assertEquals( "foo bar baz", $remote_comment->comment_content ); | |||
| } | |||
|
|
|||
| public function test_unapprove_comment() { | |||
|
|
|||
| $this->assertEquals( 1, $this->server_replica_storage->comment_count( 'approve' ) ); | |||
There was a problem hiding this comment.
It would be good to use space to group the different tests that are happening here a bit better.
Added whitespace and additional comment to make the comment unapprovral class clearer
lezama
added
[Package] Sync
[Team] Poseidon
[Status] Ready to Merge
lezama
approved these changes
Apr 4, 2017
matticbot
removed
the
[Status] Ready to Merge
gititon
added
[Status] Needs Review
eliorivero
pushed a commit
that referenced
this pull request
Apr 25, 2017
* Changelog: initial commit for 4.9 release. * Changelog: add #6929 * Changelog: move old changelogs to changelog.txt * Readme: restore deleted release post link. The post is now live. * Changelog: add #6853 * Changelog: add #6856 * Changelog: add #6857 * Changelog: add #6884 * Changelog: add #6885 * Changelog: add #6892 * Changelog: add #6894 * Changelog: add #6898 * Changelog: add #6899 * Changelog: add #6900 * Changelog: add #6909 * Changelog: add #6927 * Changelog: add #6947 * Chagelog: add #6958 * Changelog: add #6961 * Changelog: add #6963 * Changelog: add #6965 * Changelog: add #6986 * Changelog: add #7000 * Changelog: add #7013 * Changelog: add #7015 * Changelog: add #7019 * Changelog: add #7028 * Changelog: add #6998 * Changelog: add #6999 * Changelog: add #7044 * Changelog: add #6881 * Changelog: add #6922 * Changelog: add #6940 * Changelog: add #6962 * Changelog: add #6942 * Changelog: add #6959 * Changelog: add #7018 * Changelog: add #6948 * Changelog: add #6657 * Changelog: add #7030 * Changelog: add #7048 * Changelog: add #7031 * Changelog: add #6990 * Changelog: add #6957 * Changelog: add #7027
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds sync listeners for the
comment_approved_to_unapprovedandcomment_unapproved_to_approvedactions to the Comments Sync Module for the purpose of reporting these events to the Activity Log.Changes proposed in this Pull Request:
comment_approved_to_unapprovedandcomment_unapproved_to_approvedactions to the Comments Sync ModuleTesting instructions:
phpunit --filter commentProposed changelog entry for your changes: